Skip rpath relocation of ELF files with protodesc_cold
sections
#20403
+13
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?We have multiple formulae (e.g.
ola
,openvino
,opencv
,or-tools
,pytorch
) that seem to be broken bypatchelf.rb
on x86_64 Linux.1 Thecommon thread seems to be the presence of a
protodesc_cold
section inthe ELF header.
Let's avoid breaking these bottles by skipping relocation when a binary
file has a
protodesc_cold
section. It will probably hurtrelocatability of these bottles, but that's better shipping broken
binaries.
Footnotes
https://github.com/Homebrew/homebrew-core/pull/210860#issue-2918569212 ↩