-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
cask/audit: iterate over artifacts in rosetta/signing audit #20405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bevanjkay
wants to merge
1
commit into
main
Choose a base branch
from
cask-audit-separate-artifacts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d174800
to
701a8ba
Compare
701a8ba
to
e570d16
Compare
e570d16
to
42905c4
Compare
carlocab
approved these changes
Aug 11, 2025
42905c4
to
ca04439
Compare
ca04439
to
c161409
Compare
carlocab
reviewed
Aug 11, 2025
c161409
to
34f659c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?For both
audit_rosetta
andaudit_signing
we can run into an inconsistency when two artifacts are present with differing results. This results in there being no way for the cask to passbrew audit
at present.This PR introduces a change that checks all artifacts in the appropriate situation before returning with an error.
Example: Homebrew/homebrew-cask#223456