Skip to content

cask/audit: iterate over artifacts in rosetta/signing audit #20405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Aug 11, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

For both audit_rosetta and audit_signing we can run into an inconsistency when two artifacts are present with differing results. This results in there being no way for the cask to pass brew audit at present.

This PR introduces a change that checks all artifacts in the appropriate situation before returning with an error.


Example: Homebrew/homebrew-cask#223456

@bevanjkay bevanjkay requested a review from Copilot August 11, 2025 02:43
Copilot

This comment was marked as outdated.

@bevanjkay bevanjkay force-pushed the cask-audit-separate-artifacts branch from d174800 to 701a8ba Compare August 11, 2025 02:44
@bevanjkay bevanjkay requested a review from Copilot August 11, 2025 02:44
Copilot

This comment was marked as outdated.

@bevanjkay bevanjkay force-pushed the cask-audit-separate-artifacts branch from 701a8ba to e570d16 Compare August 11, 2025 02:48
@bevanjkay bevanjkay requested a review from Copilot August 11, 2025 02:49
Copilot

This comment was marked as duplicate.

@bevanjkay bevanjkay force-pushed the cask-audit-separate-artifacts branch from e570d16 to 42905c4 Compare August 11, 2025 02:50
@bevanjkay bevanjkay requested a review from Copilot August 11, 2025 02:50
Copilot

This comment was marked as outdated.

@bevanjkay bevanjkay force-pushed the cask-audit-separate-artifacts branch from 42905c4 to ca04439 Compare August 11, 2025 03:46
@bevanjkay bevanjkay requested a review from Copilot August 11, 2025 03:46
Copilot

This comment was marked as outdated.

@bevanjkay bevanjkay force-pushed the cask-audit-separate-artifacts branch from ca04439 to c161409 Compare August 11, 2025 03:50
@bevanjkay bevanjkay requested a review from Copilot August 11, 2025 03:50
Copilot

This comment was marked as outdated.

@bevanjkay bevanjkay force-pushed the cask-audit-separate-artifacts branch from c161409 to 34f659c Compare August 11, 2025 04:12
@bevanjkay bevanjkay requested a review from carlocab August 11, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants