Cleanup internal API handling #20406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few cleanup things:
HOMEBREW_USE_INTERNAL_API
inHomebrew::API::{Formula,Cask}
. This functionality will end up living inHomebrew::API::Internal
(coming soon)formula_aliases.txt
file generation to a helper method inHomebrew::API
. This is only used in one place for now, but eventually will be used inHomebrew::API::Internal
A quick note on the last item: this means that the minimal JSON file now is in this format:
I tried a few different structures to see which was the most space-efficient when compressed, and this seemed to be the best and most readable. I'm happy to share these results if anyone is interested. Also happy to try other suggestions.
Here are the compressed file sizes: