rubydoc: fix sidebar navigation links on nested pages#21589
Open
GunniBusch wants to merge 1 commit intoHomebrew:mainfrom
Open
rubydoc: fix sidebar navigation links on nested pages#21589GunniBusch wants to merge 1 commit intoHomebrew:mainfrom
GunniBusch wants to merge 1 commit intoHomebrew:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Homebrew’s overridden YARD app.js to fix broken sidebar navigation when browsing nested RubyDoc pages (as reported in #21588), and makes minor docstring formatting tweaks in an autogenerated Sorbet RBI.
Changes:
- Add/override YARD template
app.jswith apostMessage-driven navigation handler that fetches and swaps#maincontent for sidebar navigation. - Re-run/adjust parts of the page-init logic after dynamic navigation.
- Minor comment formatting changes in
parser@3.3.8.0.rbi.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Library/Homebrew/yard/templates/default/fulldoc/html/js/app.js | Overrides YARD JS to handle sidebar navigation on nested pages by resolving URLs and swapping main content. |
| Library/Homebrew/sorbet/rbi/parser@3.3.8.0.rbi | Small docstring formatting changes in an autogenerated RBI file. |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/parser@3.3.8.0.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gniumg-source
added a commit
to gniumg-source/brew
that referenced
this pull request
Feb 18, 2026
gniumg-source
added a commit
to gniumg-source/brew
that referenced
this pull request
Feb 18, 2026
Closed
MikeMcQuaid
reviewed
Feb 22, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
This is a lot of extra code added for what should be a relatively simple regression?
@p-linnane does this related to the recent GitHub Pages work perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This fixes #21588
It overrides app.js and repairs the broken navigation.