Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #21582 by detecting legacy bottle sha256 DSL usage and preventing it from aborting formula auditing when walking historical revisions.
Changes:
- Add a new
LegacyDSLErrorexception type to represent legacy DSL usage. - Detect the legacy bottle
sha256hash-rocket form inBottleSpecification#sha256and raiseLegacyDSLError. - Update
FormulaAuditor#committed_version_infoto rescueLegacyDSLErrorwhile traversing historical formula revisions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
Library/Homebrew/formula_auditor.rb |
Rescues LegacyDSLError during committed-version history traversal. |
Library/Homebrew/exceptions.rb |
Introduces LegacyDSLError exception class. |
Library/Homebrew/bottle_specification.rb |
Expands sha256 signature and raises LegacyDSLError on legacy DSL usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Feb 22, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good once comment addressed, thanks @botantony!
Before merging: please improve both the commit message and PR title/body so it's more apparent what's being done and why.
… to catch it Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?