Skip to content

Comments

cleanup: fix file descriptor leak in cleanup_lockfiles#21611

Open
ranga-nir wants to merge 1 commit intoHomebrew:mainfrom
ranga-nir:fix/cleanup-lockfiles-fd-leak
Open

cleanup: fix file descriptor leak in cleanup_lockfiles#21611
ranga-nir wants to merge 1 commit intoHomebrew:mainfrom
ranga-nir:fix/cleanup-lockfiles-fd-leak

Conversation

@ranga-nir
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

cleanup_lockfiles leaks file descriptors by calling file.open without saving or closing the handle. Fixed by storing the handle and closing it on all code paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant