bin/brew: simplify filtering of BIN_BREW_EXPORTED_VARS#21697
Merged
Conversation
Looping over `BIN_BREW_EXPORTED_VARS` for each line of an env file is relatively inefficient. We can avoid this by constructing a regex before the loop and using that regex to match against the lines we want to skip.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ZhongRuoyu
approved these changes
Mar 9, 2026
MikeMcQuaid
reviewed
Mar 9, 2026
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Nice cleanup, thanks @carlocab!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Looping over
BIN_BREW_EXPORTED_VARSfor each line of an env file isrelatively inefficient. We can avoid this by constructing a regex before
the loop and using that regex to match against the lines we want to
skip.