Remove Brewfile.lock.json generation.

[MikeMcQuaid]

This was originally added to faciliate later functionality from other maintainers that never materialized.

I've never heard anyone say this was useful and a lot of people have complained that it's useless or annoying.

I won't merge this immediately to give people a change to comment.

[p-linnane]

Makes sense. I've also never understood the purpose, so your explanation makes sense.

[colindean]

I have no objections. I've got a line for Brewfile.lock.json in every .gitignore in a repo with a Brewfile.

[jacobbednarz]

works for me!

[Brett-Best]

I actually found this helpful and had it committed to the repository.
It had a bunch of information about the environment in a last known working state which made finding where things broke a bit easier to debug.

It's not a big deal but perhaps it could default to not generating the lockfile and make it opt in only.

[georgettica]

I also used it and was surprised it was removed. I used it to un-quarantine casks after each release.

[Xe]

My CI relied on this for caching homebrew packages so they didn't have to be downloaded twice (this saves up to 10 minutes per CI run). Is there a way to re-enable spacebar heating?

[MikeMcQuaid]

Thanks for chiming in @georgettica @Xe! Can you elaborate on how you used/consumed this? Thanks!

[georgettica]

As I didn't have a automated way to test what packages have changed on my machine, I added this file to my git and for each cask that was updated I force the PKG to be un-quarantined, this reduce the "are you sure this package is secure" warning

[jasonkarns]

Was there a deprecation period for the --no-lock option? I have loads of scripts and applications whose bootstrap process uses brew bundle --no-lock that are all failing now with Error: invalid option: --no-lock.

Considering that --no-lock option is now redundant; it would have been nice to get deprecation warnings to prepare scripts and tooling for removal before dropping the option.

(I'm assuming there weren't any deprecation warnings, because I run my tooling cleanup script almost weekly and never noticed any warning to this effect. Unless I missed it?)

[Xe]

Thanks for chiming in @Xe! Can you elaborate on how you used/consumed this? Thanks!

GitHub actions. I wanted to avoid installing packages needlessly (this massively speeds up CI, you have no idea, it can save two digits of minutes per run) so I cache the /home/linuxbrew folder in GitHub Actions caches. Brewfile.lock.json changing means that the cache can be invalidated.

[MikeMcQuaid]

@Xe Thanks! Could you open an issue for that functionality (GitHub Actions caching) as I think it'd be valuable and may make more sense in Homebrew/brew.