Skip to content

Update Ruby to 3.2.8 and further updates to enable CI to run on GitHub again#910

Merged
suzymoat merged 7 commits intodevelopfrom
update-github-workflow
Jun 16, 2025
Merged

Update Ruby to 3.2.8 and further updates to enable CI to run on GitHub again#910
suzymoat merged 7 commits intodevelopfrom
update-github-workflow

Conversation

@suzymoat
Copy link
Member

@suzymoat suzymoat commented May 27, 2025

Changes in this PR

Update Ruby version, and further updates required to enable CI to run successfully on GitHub again

@suzymoat suzymoat force-pushed the update-github-workflow branch from b8fcb52 to 3b6d5fc Compare May 27, 2025 13:42
@suzymoat suzymoat changed the title Upgrade actions/cache to v4 Update GitHub workflow May 27, 2025
@suzymoat suzymoat force-pushed the update-github-workflow branch from a0c3a73 to 3e005c2 Compare May 27, 2025 14:21
suzymoat added 2 commits May 27, 2025 16:41
ShellCheck started throwing the following warning:
"SC3061 (warning): In POSIX sh, read without a variable is undefined."

for lines 27 and 49 of script/no-docker/setup, both of which read:

read -r

It seems that this syntax is only supported in some shells, e.g. bash, and not
POSIX sh - e.g. see
https://unix.stackexchange.com/questions/143952/why-does-the-read-command-not-take-interactive-options-when-run-by-sh
https://unix.stackexchange.com/questions/650662/how-to-get-user-input-with-a-prompt-into-a-variable-in-a-posix-compliant-way

Changed lines from

read -r

to

read -r REPLY

and warning disappeared.
@suzymoat suzymoat force-pushed the update-github-workflow branch from b9e52eb to 586f836 Compare June 16, 2025 09:38
Not updating to Ruby 3.4.4 yet, as does not yet appear to be supported
by foreman:

https://github.com/ddollar/foreman
https://github.com/ddollar/foreman/blob/master/.github/workflows/ci.yml
@suzymoat suzymoat force-pushed the update-github-workflow branch from 586f836 to 6da6da4 Compare June 16, 2025 12:31
@suzymoat suzymoat changed the title Update GitHub workflow Update Ruby to 3.28 and further updates to enable CI to run on GitHub again Jun 16, 2025
@suzymoat suzymoat changed the title Update Ruby to 3.28 and further updates to enable CI to run on GitHub again Update Ruby to 3.2.8 and further updates to enable CI to run on GitHub again Jun 16, 2025
@suzymoat suzymoat requested a review from tobiaspreis June 16, 2025 12:49
@suzymoat suzymoat merged commit 9e9d867 into develop Jun 16, 2025
1 check passed
@suzymoat suzymoat deleted the update-github-workflow branch June 16, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants