Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
show slave statusThis syntax is deprecated and will be removed in future MySQL versions (
SHOW REPLICA STATUSshould be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools.Depends on:
show slave statusdolthub/vitess#381show slave statusdolthub/go-mysql-server#2767Support suffix arrays larger than 4GB by avoiding uint32 overflows when matching chunk suffixes.
nildefaults with empty stringNeeded for dolphie.
related: Tool dolphie needs
@@admin_versionsystem variable to return a numeric type. dolthub/dolt#8585 (comment)GMS PR: Add schema to StatsQualifier for schema databases dolthub/go-mysql-server#2762
This isn't the best perf win on linux, but it counteracts the
sql.Rowinterface PR which otherwise would swing merge join +30% in the wrong direction.go-mysql-server
NO_AUTO_CREATE_USERoption insql_modeOlder MySQL 5.7 Docs; https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_no_auto_create_user
We already do this by default, so this is just parsing the option and does nothing.
show slave statusThis syntax is deprecated and will be removed in future MySQL versions (
SHOW REPLICA STATUSshould be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools.Depends on: Add support for
show slave statusdolthub/vitess#381Hotfix for Enum conversion issue:
enum conversion type has unexpected results dolthub/dolt#8598
Doesn't address real issue, which revolves around conversion for
CASE.This is a followup to the comments on this PR:
innodb_buffer_pool_sizesystem variabledocs: https://dev.mysql.com/doc/refman/8.4/en/innodb-parameters.html#sysvar_innodb_buffer_pool_size
fixes: Support
SET SQL_MODE='NO_AUTO_VALUE_ON_ZERO'dolthub/dolt#8584I'm pretty sure this needs to match with
memory.NewDatabase(dbName)on line 135vitess
This PR adds support for parsing the mariadb table options listed here:
https://mariadb.com/kb/en/create-table/#table-options
They are all no-ops (much like many of the MySQL table options)
related: Make Dolt work with mydumper dolthub/dolt#8592
start transaction with consistentas no-oprelated: Make Dolt work with mydumper dolthub/dolt#8592
CREATE USERstatements to quote the auth pluginMySQL allows the auth plugin name to be quoted or unquoted, but our parser previously only supported the unquoted mode for most forms of
CREATE USER. This change adds support for the following forms:CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin';CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin' BY random password;CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin' BY 'password';show slave statusThis syntax is deprecated and will be removed in future MySQL versions (
SHOW REPLICA STATUSshould be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools.AuthServerto support multiple authentication methodsIn preparation of supporting
caching_sha2_passwordauthentication, this change applies the refactoring from Refactor authentication server plugin mechanism vitessio/vitess#8503 to our fork of Vitess so that we can more easily support multiple authentication methods.Related to: Support
caching_sha2_passwordauthentication method dolthub/dolt#8496Closed Issues