Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
For structs that are exclusively used in interfaces, there's no reason to not use pointer receivers instead of value receivers. Using value receivers can cause the struct to be copied every time the method is invoked.
Pointer receivers are also more correct here: copying the struct means that changes to the ImmutableValue field (such as setting its Buf field in ImmutableValue.GetBytes) won't be saved when the method exits, defeating the caching of values loaded from storage.
Allows a replica Dolt sql-server to connect to a MySQL source via SSL when the
SOURCE_SSLconfiguration parameter is supplied.Depends on: Add support for SSL connections to a source MySQL server dolthub/go-mysql-server#2930
The
dolt archivecommand is extra safe, and doesn't cleanup table files is converts. The --purge flag will delete table files after the conversion is done.go-mysql-server
ConvertToBytes is a commonly called function to get the string representation of a value. However, it has some unnecessary allocations where a child function allocates a byte buffer, only for the result to be copied into the buffer provided by the parent function. In other places we needlessly round-trip between string and []byte.
This PR improves performance by removing some of these unneeded copies. In places where ConvertToBytes calls a function that allocates a buffer (instead of using the buffer that ConvertToBytes can provide), we can optimize by using the returned value without copying it again.
Dolt shows a 7% improvement in the
types_table_scanbenchmark.We can potentially do even better by allowing these child functions to take a buffer, removing the need for an extra allocation.
Adds GMS support for the
SOURCE_SSLMySQL replication configuration param.stddev_pop(),stddev_samp(),var_pop(),var_samp(), and aliasesThis PR implements
STD()andVARIANCE()and its aliases.docs: https://dev.mysql.com/doc/refman/8.4/en/aggregate-functions.html#function_std
syntax: add
var_sampto keywords dolthub/vitess#409fixes: Request for
STDEV_POP()(and aliases) andVAR_POP()(and alias) dolthub/dolt#9088Dolt uses functions in the sql package to create and then parse CREATE TABLE statements as part of the merge process. Therefore, we need the ability to create these statements for other dialects, just as we do for MySQL.
This PR also exposes a Noop auth method for the same use case.
vitess
var_sampto keywordsSOURCE_SSLreplication optionCaught in PR.
Closed Issues
STDEV_POP()(and aliases) andVAR_POP()(and alias)