Skip to content

handbrake 1.10.0 #232929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

handbrake 1.10.0 #232929

wants to merge 1 commit into from

Conversation

botantony
Copy link
Contributor

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` meson labels Aug 9, 2025
@botantony botantony force-pushed the bump-handbrake-1.10.0 branch from 76c81f4 to a64c7c8 Compare August 9, 2025 13:31
@daeho-ro daeho-ro added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. linux-arm Linux ARM is specifically affected labels Aug 10, 2025
@daeho-ro daeho-ro force-pushed the bump-handbrake-1.10.0 branch 2 times, most recently from 9147c16 to 94fa548 Compare August 10, 2025 07:52
@daeho-ro
Copy link
Member

@daeho-ro daeho-ro force-pushed the bump-handbrake-1.10.0 branch from 94fa548 to 8097dbc Compare August 10, 2025 08:07
@daeho-ro daeho-ro removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 10, 2025
@daeho-ro daeho-ro force-pushed the bump-handbrake-1.10.0 branch 2 times, most recently from c42e3fc to 7f35353 Compare August 10, 2025 09:03
@carlocab carlocab requested a review from Copilot August 10, 2025 09:53
Copilot
Copilot AI reviewed Aug 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates HandBrake formula from version 1.9.2 to 1.10.0, including URL and checksum changes, removal of autobump restriction, and addition of Linux ARM-specific build fixes.

  • Version bump from 1.9.2 to 1.10.0 with updated source URL and SHA256 checksum
  • Removal of no_autobump! restriction that previously required manual review
  • Addition of Linux ARM build fixes including SVE2 disabling and AArch64 assembly patch

@daeho-ro
Copy link
Member

carlocab
carlocab reviewed Aug 10, 2025
View reviewed changes
Formula/h/handbrake.rb
Comment on lines +57 to +103
if OS.linux? && Hardware::CPU.arm?
# Disable SVE2 for ARM builds, as it causes issues with the x265 module.
inreplace ["contrib/x265_10bit/module.defs", "contrib/x265_12bit/module.defs", "contrib/x265_8bit/module.defs"],
"-DENABLE_CLI=OFF",
"-DENABLE_CLI=OFF -DENABLE_SVE2=OFF"

# Fix AArch64 assembly for pixel-util.S
(buildpath/"contrib/x265/A09-aarch64-fix.patch").write <<~PATCH
diff --git a/source/common/aarch64/pixel-util.S b/source/common/aarch64/pixel-util.S
index e2b31e4..1bcaf4a 100644
--- a/source/common/aarch64/pixel-util.S
+++ b/source/common/aarch64/pixel-util.S
@@ -860,7 +860,7 @@ function PFX(scanPosLast_neon)
lsl w13, w13, w6
lsl w15, w15, w6
extr w14, w14, w13, #31
- bfc w15, #31, #1
+ bfm w15, wzr, #31, #31
cbnz w15, .Loop_spl_1
.Lpext_end:
strh w14, [x2], #2
PATCH
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be simpler if we could just get this to use Homebrew x265, so we don't have to fix this issue in multiple places. Is there no way to do that here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could try, but they publish their own version for many dependencies and this make it more harder than think.

@carlocab carlocab added the rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR label Aug 10, 2025
@carlocab carlocab marked this pull request as draft August 10, 2025 11:38
@daeho-ro daeho-ro force-pushed the bump-handbrake-1.10.0 branch 2 times, most recently from 55d1dbc to 5f1784f Compare August 10, 2025 13:43
@daeho-ro daeho-ro force-pushed the bump-handbrake-1.10.0 branch from 5f1784f to 9980f22 Compare August 10, 2025 14:00
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 12, 2025
@carlocab carlocab removed the stale No recent activity label Aug 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 15, 2025
@carlocab carlocab added in progress Stale bot should stay away and removed stale No recent activity labels Aug 15, 2025
@cho-m cho-m mentioned this pull request Aug 15, 2025
Merged
@botantony botantony deleted the bump-handbrake-1.10.0 branch August 15, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

@daeho-ro daeho-ro daeho-ro left review comments

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away linux-arm Linux ARM is specifically affected meson rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@botantony @daeho-ro @carlocab