dolt 1.58.3

[BrewTestBot]

Created by brew bump

---

Created with brew bump-formula-pr.

release notes

# Merged PRs
dolt

9668: Initialize a branch's working set when referenced as a branch-revision database

When a new branch is pushed to a SQL server through the RemotesAPI, that branch will not have its working set initialized yet. If a customer accesses that branch as a branch-revision database (e.g. mydb/my_new_branch) and performs a write operation, the lack of a working set will cause an error. This change fixes that case by initializing a branch-revision database's working set if it has not been created yet.
9667: Fix another primary key ordering test
9665: A Primary Key BATS test to unskip.

Found testing Cursor Agent with GPT-5
9655: Skip flaky 'archive: too few chunks' test in Lambda environment
9649: Removed root object presence from some locations

Root objects occupy the same namespace as tables, however they shouldn't be returned in places that expect to see only tables. This PR allows for a distinction when querying for names, so that locations that only work with tables (such as some system tables) no longer receive root object names.

Required for:

Fixed sequences breaking some statements dolthub/doltgresql#1731


9648: Bug fix: ensure dolt_checkout() initializes a branch's working set

dolt_checkout() already had logic to initialize a branch's working set if one was not available, but the error it expected to see to trigger that logic was not being returned by the functions it called. This changes the checkoutExistingBranch() function so that it also resolves the working set for that branch and returns a doltdb.ErrWorkingSetNotFound error if the working set is not available.
9647: Refactor SetSystemVar and GetRowsForSql
9646: Add UUID key recommendation to default AGENT.md

I notice that Claude Code likes auto_increment primary keys but Dolt likes UUID keys better. So, I added a section to AGENT.md.
9642: Fix table usage during merge

We would always assume that tables are used in certain situations (rather than root objects), which would lead to a panic.
9639: Small fixes to ci, --help & valid branch names

Two small changes to CI:

dolt ci import now requires that the branches you list under on.action, on.pull_request are valid branch names. This also blocks off attempting to use the * wildcard identifier, which we do not support.
I also expanded the dolt ci import --help page to include the specification for the workflow yaml files.


9638: cache keys in iters to reduce gc

Companion PR: allocate fewer sql.Rows dolthub/go-mysql-server#3146
9637: dolthub/dolt#9582 - Fix cherry-pick timestamp preservation

Fixes dolthub/dolt#9582

Cherry-pick now preserves original commit timestamp during operations.
9635: Stop processing earlier when dolt_pull() is a no-op

User demonstrated that a no-op pull was taking far too long. Turns out we should be stopping processing but instead do a lot of unnecessary status printing computation only to throw it away. This change just short circuits any work if the current branch is already up-to-date.

go-mysql-server

3152: Validate trigger name length is not over 96 chars

We weren't enforcing any name length constraints on triggers, and when customers created triggers with very long names (i.e. over 64 characters, the MySQL limit), they could encounter problems with table schemas that don't support longer lengths.

In this change, we apply a max trigger name length of 96 characters and reject CREATE TRIGGER statements that create triggers with names longer than that limit. We chose 96 characters for the limit, instead of copying MySQL's 64 character limit, so that this change would not break existing applications that are creating trigger names slightly longer than MySQL's 64 character limit.
3150: Misc code clean up
3147: dolthub/go-mysql-server#3144 - Fix parseErr tracing to show error messages instead of memory addresses

Fixes dolthub/go-mysql-server#3144

Add Error() method to parseErr struct so tracing systems show actual error messages instead of memory addresses like "{0xc006f85d80}".
3146: allocate fewer sql.Rows

This PR removes extra sql.Row allocations where it has no impact on logic.

Doltgres error: Use AppendAndSliceString instead of AppendAndSliceBytes dolthub/doltgresql#1735
3145: fix panic over SetOps with joins and subqueries

The analyzer rule assignExecIndexes will apply a StripRowNode over any joins within a subquery.

The analyzer rule finalizeUnions recursively calls the analyzer (calling assignExecIndexes), resulting in StripRowNodes getting applied twice.

The double stripping results in rows that are too short and panics.

This PR tells the finalizeUnions selector to skip assignExecIndexes, preventing the nested StripRowNodes.

Also has some small formatting and naming clean up.

fixes: handler caught panic: runtime error: slice bounds out of range on SELECT...EXCEPT query dolthub/dolt#9631
3142: Add support for DELETE ... RETURNING

Adds support for the RETURNING clause in DELETE statements. This syntax is supported in Postgres/Doltgres, but not in Dolt/GMS/MySQL.

Tests for this functionality are in the associated Doltgres PR: Support for DELETE ... RETURNING dolthub/doltgresql#1712
3139: Remove the go-kit dependency

This library depends on https://github.com/go-kit/kit.

It looks to only use this for this single package: https://github.com/go-kit/kit/blob/master/metrics/discard/discard.go

Although the usage of this package is safe, the go-kit library hasn't been maintained since 2023 - and is throwing some warnings in our security scanning.

Can we look at removing usage of this external library?

The proposed PR replaces it with an internal interface - but also allows configuration via a config options.

Alternatively it could maybe be dropped completely? It's only a no-op.

Closed Issues

9509: Add agent.md to dolt_docs populated on init
9631: handler caught panic: runtime error: slice bounds out of range on SELECT...EXCEPT query
9628: In the result of the following query, the dashboard_id field appears to be incorrect — it returns the value of entity_id instead of the actual dashboard_id.
3144: Planbuilder: Traces do not record parse exceptions correctly

View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.58.3.

---

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.