Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
Fixes #9725
Newly promoted primary could reuse AUTO_INCREMENT values due to a stale in-memory tracker. On promotion, we now synchronously refresh AUTO_INCREMENT trackers for databases already loaded in the session, aligning sequences with the current working sets so the first post-promotion inserts do not reuse existing IDs.
only_full_group_byin sysbenchSince our group validation much more closely aligns with MySQL, we discovered that sysbench script
groupby_scan.luais not valid in MySQL without disablingONLY_FULL_GROUP_BYinsql_mode. This PR fixes the local test scripts and the benchmark runners to accept aconfig.yamlwith thesql_modeset.Changes the event collector/emitter to drop old events and not grow unbounded when events can't be delivered.
The event collector already batched 64 events per request when
LogEventmessages were being sent successfully. However, when there are issues sendingLogEventmessages, the events queue up, with no upper bound, and eachLogEventrequest gets larger and larger. This change limits the tracked "unsent" events to that existing 64 event batch size.This contains some fixes related to calling Dolt functions in Doltgres.
Required by:
Rework CliContext and LateBinderyQueryist lifecycle so that CliContext itself is
Closed when we are done with it. If it instantiated the LateBinderQueryist, it closes it at that time.Previously LateBinderQueryist was responsible for returning a
closer(), which a caller ofCliContext.QueryEnginecould see as non-niland call at the end of its work. This works well when a QueryEngine is used exactly one time or when QueryEngine usage is completely nested, as is the case with the backslash command implementations called fromdolt sql. But in tests, we sometimes use command instances back-to-back, on the same CliContext instance, where it results in using the Queryist after it has already been closed.This PR also reworks result types so that callers of QueryEngine can know if they are connected locally or remotely and if the QueryEngine interaction they are making is the first one in the session. Some callers need to inspect that state to implement helpful error checks and guard rails, and they were previously using things like a non-nil
closerand interface casts to concrete types to implement these checks.Adds
dolt_testssystem table. The table currently has no functionality, but behaves similarly to the other writable system tables likedolt_ignoreanddolt_query_catalog.go-mysql-server
show table statusfixes dolthub/dolt#6894
SHOW VARIABLESdisplay boolean values as ON/OFF to match MySQLChanges the output of
SHOW VARIABLESto match MySQL's output, where boolean values are shown asONorOFF. Also adds definitions for two replication related system variables.fixes dolthub/dolt#9403
fixes dolthub/dolt#9699
Fixes dolthub/dolt#4998
Still need to allow group by unique non-nullable columns (dolthub/dolt#9700)
Query plans needed to be updated because Subquery.String and GroupBy.String changed. The latter was due to SelectedExprs being renamed to SelectDeps.
Dolt bump: dolthub/dolt#9704
Closed Issues
show table status"Comments" column does not match MySQL "Comment" columnGroupByvalidation not running on nodes wrapped inHaving,Project, orSort(validation is also way too strict when it does run)View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.58.6.