dolt 1.59.7

[BrewTestBot]

Created by brew bump

---

Created with brew bump-formula-pr.

release notes

# Merged PRs
dolt

9823: dolthub/dolt#9817 - Add bats for binary ops

Fixes dolthub/dolt#9817

Companion dolthub/go-mysql-server#3208, dolthub/dolt#9824
9822: fix missed context canceled error for dolt_test_run()

Changes:

delete  Close() calls missed in fix context cancel in dolt_test_run() when running dolt sql-server dolthub/dolt#9811
adds a test for single result assertion
add missing cases for int types


9819: Allow foreign keys to reference dolt_branches system table

Allows creating foreign keys on user tables that reference the name column on the dolt_branches table.

Fixes: Extending Dolt system tables, specifically dolt_branch, via foreign key dolthub/dolt#9712

go-mysql-server

3210: Copy parent row in lateralJoinIterator.buildRow

fixes dolthub/dolt#9820

Also rename left and right to primary and secondary to follow the same pattern as other join iterators
3209: Convert values to strings when evaluating bit_length

Fixes dolthub/dolt#9818
3208: dolthub/dolt#9817 - Fix binary operations return type to be uint64

Fixes dolthub/dolt#9817
3205: Relax restriction that was preventing us from caching the result of subqueries.

Subquery caching rules onceAfterAll dolthub/go-mysql-server#1470 was supposed to, among other things, add restrictions to when we generate CachedResults nodes to cache subquery results. However, the added check is overly broad, and as a result it became impossible to actually cache subquery results. Currently, there is not a single plan test that contains a CachedResults node in the output plan.

The cacheSubqueryAliasesInJoins function has a comment:
//The left-most child of a join root is an exception that cannot be cached.
No rationale is given for this. Looking at it, it seems like we used to generate CachedResults nodes before we finished resolving references in the query, and now we wait until after. So it's possible that this is the reason for the restriction, and the entire check is no longer necessary.

Either way, the implementation is more restrictive than the comment would suggest. Due to how the algorithm tracks state via function parameters, it doesn't propagate state from a child node to it's parents/siblings, and the flag for recording that it's encountered a subqeury gets unset. As a result, no Subqueries will actually be cached.

This PR fixes the tree walk to correctly remember once it's encountered a subquery and allow subsequent subqueries to be cached. This is still more broad than the comment would suggest, since it doesn't require that this subquery appear in the left-most child of the join.

Among the changed plan tests, we see that CachedResults nodes are now emitted. Most of them are the children of HashLookups, but there are some that are the children of InnerJoin and SemiJoin nodes where one of the things being joined is a subquery.

Closed Issues

9712: Extending Dolt system tables, specifically dolt_branch, via foreign key
9820: LATERAL keyword causes JOIN to incorrectly return empty result
9818: BIT_LENGTH() returns incorrect results for int
9817: Bitwise operations with negative numbers always return 9223372036854775807

View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.59.7.

---

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.