Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
While working on importing dumps in Doltgres, I found out that data wasn't being written correctly in some circumstances. Turns out that the new adaptive encoding is incomplete, and therefore broken, and any columns over the inline threshold will be truncated. This truncation results in a panic whenever the field is read, since the serialized size does not match the data, causing OOB access.
This should be safe to change since existing databases will simply swap to using the old ref approach until adaptive is fixed, where we can then swap back to the adaptive encoding (since the ref code is still in the codebase). I've already spoken to Nick who will lead the fix once he has returned next week.
go-mysql-server
UNION ALLwithNULL BLOB SELECTreturningNULLfor all valsFixes #3216
fixes dolthub/dolt#9821
fixes dolthub/dolt#9834
PIPES_AS_CONCATmodeFixes dolthub/dolt#9791
depends on dolthub/vitess#432
INand=operator logicFixes dolthub/dolt#9812
vitess
PIPES_AS_CONCATmode parsingPart of dolthub/dolt#9791
GMS uses Vitess code to encode responses into the MySQL wire format.
Testing for this change is in the corresponding GMS PR.
Closed Issues
View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.59.10.