Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
UPDATE statements return the number of rows that changed as a result of the operation. This requires comparing the new and old values for the rows.
Because IndexedJsonDocument didn't properly implement the ComparableJSON interface, these values were being fully reconstructed in memory for the comparison, which was needlessly slow. Implementing the interface allows comparing two documents to be logarithmic on document size instead of linear.
doltremoteapi returns RepoTokens on some RPC interactions. When Dolt mirrors the token back to doltremoteapi, doltremoteapi can check if the current repo state matches the token state and if it does, it can avoid doing some I/O work to refresh its current view of the repository.
After a Commit(), the client was not clearing its view of the repoToken, and the server was not returning the new RepoToken on a successful commit. This meant that the client was potentially seeing stale data for the repository if its RepoToken represented the previous committed state and if its requests landed on a doltremoteapi replica where that state was also the state of the repository in memory.
In multi-process concurrency against a ChunkStore, clients are expected to refresh their view of storage after a Commit and after a call to Rebaes. This corresponds to clearing our RepoToken, so that doltremoteapi will Rebase the store and return a new RepoToken which reflects the refreshed state.
go-mysql-server
Fixes dolthub/dolt#9927
fixes dolthub/dolt#9936
fixes dolthub/dolt#7372
makes progress on dolthub/dolt#9739
Fixes dolthub/go-mysql-server#3259
Fixes dolthub/dolt#9935
Fixes dolthub/dolt#9927
Fixes dolthub/dolt#9053
This PR provides an optional pure Go regex engine that allows building go-mysql-server without CGO.
The default build process (using ICU via CGO) remains unchanged.
Implementation
go-icu-regexlibrary. (internal/regex/regex_cgo.go)CGO_ENABLED=0or-tags=gms_pure_go): Uses a new implementation based on Go's standardregexppackage. (internal/regex/regex_pure.go)Build selection is handled via Go build tags.
Compatibility Notes
The pure Go engine trades compatibility for portability, as it is based on standardregexppackage.Notable limitations compared to ICU include:
This change allows running the server in pure Go for users who can accept the trade-offs, providing greater build flexibility.
select * fromSubqueryAliases into the innermost SubqueryAliasClosed Issues
EOFas a MySQL errorView the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.59.19.