Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
DOLT_DIFFtest withINandNOT INPreviously, methods in
patch_generator.gowould returnio.EOFto indicate that it had finished diffing two branches and that there were no more differences.While this was a simpler interface, it meant that callers had to know whether or not it was possible for the returned error to be
io.EOFand had to remember to check for it. Otherwise, that error could get propagated to the method's own caller.This caused a correctness bug, where a function was assumed to never return
io.EOFinstead of checking for it.A safer approach is to have a separate return value to indicate whether or not there can possibly be any more patches. That way, failing to check this value would become a compiler error.
Fixes dolthub/dolt#9955
docker-entrypoint.shnow matches the order of operations of MySQL's entry point, user and database environment variables are configured before thedocker-entrypoint-init.d/directory.serverDockerfile.docker-entrypoint-initdb.dfiles are now piped directly intodolt sqlto fixArgument list too longerror when parsing a large dump.docker-entrypoint-initdb.dfiles now output their query results.run_containerinbatsintegration tests to reduce false positives.go-mysql-server
fixes dolthub/dolt#9917
NOT INFixes dolthub/dolt#9977
Companion dolthub/dolt#9979
fixes dolthub/dolt#9973
ENCLOSED BYignoring terminator inside of field when usingLOAD DATA INFILEFixes dolthub/dolt#9969
fixes dolthub/dolt#9963
In #3166, I had skipped adding aggregate function dependencies to the from scope of the Having node because they were being included in the select expressions during GroupBy validation. However, removing them caused other scoping issue.
So I undid the skip, and instead of using the select expressions from the innermost Project node, we now use the select expressions from the innermost Project node that is not a direct child of a Having node. This exposed a bug where we were not able to resolve aliases in OrderBy expressions so I added Alias expressions to the select dependency map used for resolving OrderBy and Select expressions
Closed Issues
INsubquery predicate withNOT INincorrectly returns rows when queryingDOLT_DIFFLOAD DATAView the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.76.0.