Skip to content

Conversation

@branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hatch currently does not correctly handle a SOURCE_DATE_EPOCH before 1980 like other build backends. This will be fixed when pypa/hatch#1999 is released, so let's clarify these misleading comments

Copilot AI review requested due to automatic review settings October 25, 2025 02:49
@branchvincent branchvincent added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates comments across multiple Homebrew formula files to clarify the reason for setting SOURCE_DATE_EPOCH to "1451574000". The change replaces misleading comments that suggested the source code lacked a valid SOURCE_DATE_EPOCH with accurate comments explaining that hatch (the build backend) doesn't support values before 1980. The updated comments also include a reference to the upstream issue that will fix this limitation.

Key changes:

  • Replaced inaccurate comment text with technically correct explanation
  • Added issue link for tracking when the workaround can be removed

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Formula/v/vunnel.rb Updated comment to clarify hatch limitation and added issue reference
Formula/t/terraform-iam-policy-validator.rb Updated comment to clarify hatch limitation and added issue reference
Formula/s/streamrip.rb Updated comment to clarify hatch limitation and added issue reference
Formula/s/snakefmt.rb Updated comment to clarify hatch limitation and added issue reference
Formula/s/sigma-cli.rb Updated comment to clarify hatch limitation and added issue reference
Formula/s/sherlock.rb Updated comment to clarify hatch limitation and added issue reference
Formula/s/sceptre.rb Updated comment to clarify hatch limitation and added issue reference
Formula/s/sarif-tools.rb Updated comment to clarify hatch limitation and added issue reference
Formula/r/rich-cli.rb Updated comment to clarify hatch limitation and added issue reference
Formula/r/remarshal.rb Updated comment to clarify hatch limitation and added issue reference
Formula/p/prowler.rb Updated comment to clarify hatch limitation and added issue reference
Formula/p/poetry.rb Updated comment to clarify hatch limitation and added issue reference
Formula/p/podcast-archiver.rb Updated comment to clarify hatch limitation and added issue reference
Formula/o/otterdog.rb Updated comment to clarify hatch limitation and added issue reference
Formula/m/manim.rb Updated comment to clarify hatch limitation and added issue reference
Formula/m/mac-cleanup-py.rb Updated comment to clarify hatch limitation and added issue reference
Formula/l/literate-git.rb Updated comment to clarify hatch limitation and added issue reference
Formula/k/kaskade.rb Updated comment to clarify hatch limitation and added issue reference
Formula/j/jrnl.rb Updated comment to clarify hatch limitation and added issue reference
Formula/j/jiratui.rb Updated comment to clarify hatch limitation and added issue reference
Formula/g/gptme.rb Updated comment to clarify hatch limitation and added issue reference
Formula/d/dooit.rb Updated comment to clarify hatch limitation and added issue reference
Formula/d/dolphie.rb Updated comment to clarify hatch limitation and added issue reference
Formula/c/cyclonedx-python.rb Updated comment to clarify hatch limitation and added issue reference
Formula/c/copier.rb Updated comment to clarify hatch limitation and added issue reference
Formula/c/commitizen.rb Updated comment to clarify hatch limitation and added issue reference
Formula/c/codelimit.rb Updated comment to clarify hatch limitation and added issue reference
Formula/b/bbot.rb Updated comment to clarify hatch limitation and added issue reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 25, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 25, 2025
Merged via the queue into Homebrew:main with commit a305820 Oct 25, 2025
23 checks passed
@branchvincent branchvincent deleted the hatch-epoch-bug branch October 25, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants