Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
AWS Go SDK needs an io.ReadSeeker in the UploadPartInput in order to supply a Content-Length header. Supplying an io.MultiReader was resulting in an error.
Fix this for now by making a temporary copy of the data and using a bytes.NewReader instead.
go-mysql-server
IsNullablereturn true for nullable datetime functionsfixes dolthub/dolt#10092
I updated the datetime functions'
IsNullablefunction based on whether they could return nil, usingfunction_queries.gofrom #3305 as a reference.We should probably do an audit of all our functions to make sure
IsNullableis correct.Fixes dolthub/dolt#10083
View rebinding no longer requires the invoker to have CREATE VIEW grant if the definer already did.
mockDefinerto clone the cached privilege state with explicit global grants.resolveViewto mock definer for CREATE VIEW grant since it's implicitly required to exist.0andfalseFixes dolthub/dolt#10075
Our datetime functions were not returning the correct results for
0andfalse. This was because we were using0000-01-01aszeroTime(which evaluates to true using Go'stime.IsZero) and then extracting datetime information from that timestamp. Using0000-01-01aszeroTimewas also giving incorrect results for some functions when the input timestamp was actually0000-01-01, since it was being equated aszeroTime.Also, depending on whether
falsewas read asfalseor0, we were also not able to convert it tozeroTime.This fix involves updating
zeroTimetotime.Date(0, 0, 0, 0, 0, 0, 0, time.UTC), which has the timestamp-0001-11-30. Since negative years are not valid in MySQL, this timestamp would not conflict with a non-zero timestamp. We also add in checks forzeroTimeto make sure functions return the correct value fromzeroTimeinstead of simply extracting datetime information from the timestamp.Dolt bump PR: dolthub/dolt#10084
Closed Issues
DAYOFMONTHResultView the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.78.1.