Merged
Conversation
chenrui333
approved these changes
Dec 12, 2025
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
This change removes doltgres-specific index logic from Dolt and fixes various bugs in index lookup and type conversion logic that were preventing doltgres from using the unified index logic in the first place.
See: remove doltgres index implementation, various bug fixes dolthub/doltgresql#2093
adapters.TableAdapterto handledolt_statusand other table conversions for integrators (a.k.a. Doltgres)A recent change to cherry-pick tests required
dolt_statusto display its staged column as abytetype to overcome MySQL's wire protocol being unable to distinguish Boolean types. This had the side affect of breaking Doltgres. This fix adds Dolt system table adapters for integrators (i.e. Doltgres).adapters.TableAdapterallows for tables in general to be wrapped or overwritten with different implementations.adapters.TableAdapterto allow integrator's to overwrite or wrap existing table implementations.adapters.DoltTableAdapterRegistryto automatically integrate said table adapters for Dolt system table through an interface available to integrators.SUPERUSERprivilege check indolt_purge_dropped_databasesas this should be handled by integrators.dolt_backupfor Doltgres; now handled by dolthub/doltgresql#2068.--filtercontribution fordolt diffAuthor @codeaucafe
Add
--filteroption todolt diff, enabling filtering by specific change types and fixing issues from the earlier stalled PR (#3499).Fix #1430
--filteroption for dolt diffThere was no action on the original #3499 for issue #1430; the PR was closed ~3 years ago. This PR fixes the open PR comments and updates the implementation details a bit for the RowWriting of filtered rows
go-mysql-server
Previously, we would return a "function not found" error, which was confusing and misleading.
Fixes Using a table function where a non-table function is expected results in confusing "function not found" error dolthub/dolt#10187
This PR addresses type conversion semantics during key lookups. Some type conversions were insufficient for Doltgres, and some were simply incorrect, notably the behavior when a value being converted was out of range, which could produce incorrect results.
Other fixes addressed:
ExecBuilderNodeinterface to allow Doltgres to correctly use the custom builder overrides when building row itersINandNOT INused in index lookups for doltgresTests for some of these changes only exist in Doltgres, will address before merging.
See: remove doltgres index implementation, various bug fixes dolthub/doltgresql#2093
There's a bug where filtering by a key that overflows the index column type results in incorrect lookups.
When converting the key type to the column type, we ignore in OutOfRange results, and use the max/min of the corresponding type. As a result, we perform lookups using the wrong key.
Changes:
sql.Convert()returns if the conversion result isInRange,Overflows, orUnderflows.HashInto handle overflowing keys.This fixes: need better error message when creating view with conflicting name dolthub/dolt#10177
Fixes PRIMARY KEY isn't always used in left joins dolthub/dolt#9520
In Functional Dependency Analysis, equivalence sets are sets of columns which have been determined to always be equal to each other. During join planning, we walk the join tree, read the join filters, and use these filters to compute equivalence sets which can inform the analysis.
However, we currently only look at filters on inner joins, because filters on outer joins do not unconditionally imply equivalence.
For example, in the following join query:
table_one.oneandtable_two.twohave equal values in the output. Any of the following are valid rows in the final output:vitess
This allows a server implementation to know the authenticated user without waiting for the first command interactions, such as ComQuery or ComInitDB.
Closed Issues
dolt diffshould support--filteroptionNote on Incompatibility
View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.79.0.