-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
unified-courier-tracker 1.0.0 #265001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unified-courier-tracker 1.0.0 #265001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new Homebrew formula for unified-courier-tracker, a Terminal User Interface (TUI) application for tracking packages from Blue Dart, DTDC, and Delhivery courier services.
Changes:
- New formula file for unified-courier-tracker version 1.0.0
- Manual installation approach using bash wrapper script
- Basic test to verify the --help flag
| end | ||
|
|
||
| test do | ||
| # --help should print usage and exit 0 |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test expects an exit code of 1 for the --help flag, which is unusual. Most CLI tools return exit code 0 for --help. Verify that this is the actual behavior of the application, or consider whether the exit code expectation should be 0 instead.
Formula/unified-courier-tracker.rb
Outdated
| depends_on "[email protected]" | ||
|
|
||
| def install | ||
| libexec.install "track_shipments.py" | ||
| (bin/"unified-courier-tracker").write <<~EOS | ||
| #!/bin/bash | ||
| exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "" |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formula depends on [email protected], but most Python formulas in the codebase use [email protected]. Unless there's a specific compatibility reason (which should be documented in a comment), this should be updated to use [email protected] for consistency with the broader ecosystem.
| depends_on "python@3.12" | |
| def install | |
| libexec.install "track_shipments.py" | |
| (bin/"unified-courier-tracker").write <<~EOS | |
| #!/bin/bash | |
| exec "#{Formula["python@3.12"].opt_bin}/python3" "#{libexec}/track_shipments.py" "" | |
| depends_on "python@3.14" | |
| def install | |
| libexec.install "track_shipments.py" | |
| (bin/"unified-courier-tracker").write <<~EOS | |
| #!/bin/bash | |
| exec "#{Formula["python@3.14"].opt_bin}/python3" "#{libexec}/track_shipments.py" "" |
| def install | ||
| libexec.install "track_shipments.py" | ||
| (bin/"unified-courier-tracker").write <<~EOS | ||
| #!/bin/bash | ||
| exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "" | ||
| EOS | ||
| (bin/"unified-courier-tracker").chmod 0o755 | ||
| end |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formula should include "Language::Python::Virtualenv" and use virtualenv_install_with_resources instead of manually creating a bash wrapper script. The current approach does not properly isolate dependencies and does not follow Homebrew conventions for Python applications. See examples like ranger.rb or percol.rb for the correct pattern.
Formula/unified-courier-tracker.rb
Outdated
| libexec.install "track_shipments.py" | ||
| (bin/"unified-courier-tracker").write <<~EOS | ||
| #!/bin/bash | ||
| exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "" |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exec command has an empty string argument at the end (""). This appears to be unintentional and should be removed. The proper syntax should be: exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "$@" if you want to pass through command-line arguments, or simply remove the empty string if no arguments are needed.
| exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "" | |
| exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "$@" |
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
botantony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @anir0y. This looks like a nice piece of software, but it currently does not meet the notability requirements for inclusion into Homebrew-core: https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff
For now you can create and maintain your own tap:
- https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
- https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/
Once it becomes notable enough, we would love to see it in the Homebrew-core repository
| sha256 "e7e590c455bb83e6aa36c4f53e7e742119916858af38d2ddfedad6faeff22e88" | ||
| license "MIT" | ||
|
|
||
| depends_on "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this Python version and not the latest?
| #!/bin/bash | ||
| exec "#{Formula["[email protected]"].opt_bin}/python3" "#{libexec}/track_shipments.py" "$@" | ||
| EOS | ||
| (bin/"unified-courier-tracker").chmod 0o755 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (bin/"unified-courier-tracker").chmod 0o755 |
|
|
||
| test do | ||
| # --help should print usage and exit 0 | ||
| assert_match "usage", shell_output("#{bin}/unified-courier-tracker --help") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Homebrew requires a simple test that checks if a program can do basic stuff correctly. From Formula Cookbook:
We want tests that don’t require any user input and test the basic functionality of the application. For example
foo build-foo input.foois a good test and (despite their widespread use)foo --versionandfoo --helpare bad tests. However, a bad test is better than no test at all.
|
Closing this for now due to the notability requirements. |
Adds Unified Courier tracker (TUI) formula.