install.sh: fix Linux Ruby test logic#1017
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom Aug 11, 2025
Merged
Conversation
1. Update the test code to mirror `utils/ruby.sh` more closely. 2. Test simple `require` for stdlib existence before concluding "no usable Ruby" (Arch Linux is major reason for this). 3. If no usable Ruby but Glibc is recent enough, force vendored Ruby so the install can proceed correctly. Addresses https://github.com/orgs/Homebrew/discussions/5712 and https://github.com/orgs/Homebrew/discussions/6333.
MikeMcQuaid
approved these changes
Aug 11, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks @gromgit, great work and catch here. One question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils/ruby.shmore closely.requirefor stdlib existence before concluding "no usable Ruby" (Arch Linux is major reason for this).Addresses https://github.com/orgs/Homebrew/discussions/5712 and https://github.com/orgs/Homebrew/discussions/6333.