install.sh: do not echo newline to shell_rcfile

[fkobi]

The initial installation should be as simple as possible. The newline is nice but it is 1/3rd of what the user has to do after the install.

If we want to keep it I suggest swapping the echo to printf and using \n.

[woodruffw]

I actually think this is kind of nice as-is -- without this most users will probably end up with these brew-specific initialization steps clumped up against whatever they last added to their shell's configuration, which means more visual noise.

Not a strong opinion though, another maintainer should override me if they feel more strongly about this than I do 🙂

[fkobi]

I do not have a problem with the newline itself, just with the fact that the command is there.
From my experiences people not used to working in the terminal just copy-paste commands without trying to comprehend them so in my opinion having 2 lines to copy-paste is better UX than 3.

[woodruffw]

From my experiences people not used to working in the terminal just copy-paste commands without trying to comprehend them so in my opinion having 2 lines to copy-paste is better UX than 3.

Sorry, I don't totally understand this: if they're copy-pasting, what's the material difference between it being two versus three lines? Either way they're doing a multi-line select.

[fkobi]

Assuming that they are using a multiline select is not that significant.

However the text says "Run these commands" and not "copy-paste this block of of text/commands".
I think that the fact that one can paste multiple lines into a single-line prompt is not common-knowledge for beginners (which this change targets).

[p-linnane]

I'm not inclined to change this, simply because we used to receive many reports from users not understanding these instructions. Since we moved to this format, those reports have completely dropped off.

[gromgit]

I do not have a problem with the newline itself, just with the fact that the command is there.

Your PR removes that newline, which is functional rather than cosmetic. It counters a missing newline issue that results in incorrect startup files for some users.