Open
Conversation
robbr48
requested changes
Apr 17, 2025
Contributor
robbr48
left a comment
robbr48
left a comment
There was a problem hiding this comment.
Seems to work except for the DCPLib. It no is no longer compiled and linked since it is header-only. See separate comments in hopsandcp/CMakeLists.txt.
The conflict is just because I fixed the same typo, so it is very easy to fix.
peterNordin
force-pushed
the
switch_to_cmake_part1
branch
2 times, most recently
from
e9fa0de to
a54ee01
Compare
Contributor
|
There is something wrong with fmi4c, I get the following error: |
peterNordin
force-pushed
the
switch_to_cmake_part1
branch
from
bf5b415 to
1556ca9
Compare
peterNordin
force-pushed
the
switch_to_cmake_part1
branch
2 times, most recently
from
7d3ea5e to
2a0a799
Compare
peterNordin
force-pushed
the
switch_to_cmake_part1
branch
5 times, most recently
from
9126a74 to
0acd1ed
Compare
To prevent re-downloading after cleaning code during test builds
Keep the dir to avoid fetching all code every time
Removes warning spam on newer CMake versions
Fix dcplib build on Linux and with MSVC
Use alias target compatible with older cmake
Hopefully it has tar installed in the system
Must be present for MSVC build
- Qt 5.15 was removed so downgrading - Adjust build order
peterNordin
force-pushed
the
switch_to_cmake_part1
branch
from
0acd1ed to
9e5ca6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part one of switch over to CMake, has been in progress for more than three years.
After adding DCP additional work is needed to be able to build release, but i will make a part2
This PR enables me to build all of Hopsan on Linux GCC, Windows MinGW and Windows MSVC 2019.
Including with DCP. But I do not know if it actually works in all these cases. Hopsan at least starts.
Deb build has been migrated to CMake. But flatpak/snap and Windows builds remain.