Add Better Toast Notifications and Better Zooming #5
Open
awdev1 wants to merge 2 commits intoHotDog640:mainfrom
Open
Add Better Toast Notifications and Better Zooming #5awdev1 wants to merge 2 commits intoHotDog640:mainfrom
awdev1 wants to merge 2 commits intoHotDog640:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the user experience by implementing improved toast notifications with modern styling and interactive features, and replacing the basic zoom mechanism with mouse-cursor-based zooming. The changes include visual improvements with animations, drag-to-dismiss functionality for toasts, and better WebSocket connection feedback with detailed error codes.
- Implemented fancy toast notifications with animated icons, close buttons, and swipe-to-dismiss gestures
- Added mouse-cursor-centered zoom that keeps the pointer position fixed while zooming
- Enhanced WebSocket connection error messages to display close codes and reasons
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| src/ws/Connector.ts | Modified onClose handler to receive CloseEvent parameter, added 500ms delay before calling onOpen, and implemented special 10-second reconnection delay for close code 1008 |
| src/main.ts | Replaced basic toast implementation with interactive toasts featuring close buttons, drag-to-dismiss, and improved zoom mechanism that zooms toward mouse cursor position |
| public/style.css | Added extensive styling for enhanced toast notifications including gradients, shadows, animated SVG icons, progress bars, and drag/hover effects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Errrrrrr ok.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again! This PR brings general improvements and new features to 24RC. The following is all of the changes I made:
Commit 6ba0227:
Nothing, only just pulling existing commits
Commit 0772b91:
Replaced the old zoom mech with a better zooming mech
Instead of constantly dragging and zooming a ton, You can now zoom with only the mouse
Rework the toast notifications
Make the toasts fancy looking and add better error logging