feat: footer tweaks #476
feat: footer tweaks #476
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR is detected, will deploy to dev environment |
There was a problem hiding this comment.
Pull Request Overview
Updates the footer layout and navigation structure by moving partner displays from home page to footer, redesigning footer layout with responsive grid system, and reorganizing navigation components with new input patterns.
- Moved partner listings from home page to footer with new responsive layout
- Redesigned footer to use grid-based layout with logo, navigation, and partners sections
- Refactored navigation components to use input-based nav items instead of hardcoded arrays
Reviewed Changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/shared/assets/src/lib/styles/main.scss | Updated footer background color to lighter shade |
| libs/blog/shell/feature-shell-web/src/lib/root-shell.component.ts | Added theme input to footer component |
| libs/blog/partners/ui-partners/src/lib/partners/partners.component.html | Simplified styling for transparent background |
| libs/blog/partners/ui-partners/src/lib/partners-list/partners-list.component.html | Reduced partner logo size and simplified layout |
| libs/blog/layouts/ui-navigation/src/lib/navigation/navigation.component.ts | Refactored to use input-based nav items with grid layout support |
| libs/blog/layouts/ui-navigation/src/lib/navigation/navigation.component.html | Updated template to use new grid classes and input nav items |
| libs/blog/layouts/ui-layouts/src/lib/header/header.component.ts | Added nav items array for header navigation |
| libs/blog/layouts/ui-layouts/src/lib/header/components/header-mobile-menu.component.ts | Added nav items array for mobile menu |
| libs/blog/layouts/ui-layouts/src/lib/footer/footer.component.ts | Added comprehensive footer with navigation, partners, and responsive layout |
| libs/blog/layouts/ui-layouts/src/lib/footer/footer.component.scss | Implemented responsive grid layout for footer sections |
| libs/blog/layouts/ui-layouts/src/lib/footer/footer.component.html | Created new footer template with logo, navigation, and partners |
| libs/blog/layouts/ui-layouts/src/lib/footer/components/footer-social-media-icons.component.ts | Removed heading from social media icons |
| libs/blog/home/feature-home/src/lib/home-page/home-page.component.ts | Removed partner-related imports and properties |
| libs/blog/home/feature-home/src/lib/home-page/home-page.component.html | Removed partner components from home page |
| apps/blog/src/assets/i18n/pl.json | Moved partner translations to footer section |
| apps/blog/src/assets/i18n/en.json | Moved partner translations to footer section and added new nav items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <al-navigation | ||
| [navItems]="navItems" | ||
| (navigated)="closed.emit()" | ||
| layout="vertical" |
There was a problem hiding this comment.
The layout property is being passed to the navigation component but this property was removed in the refactored NavigationComponent. This will cause a template error.
| layout="vertical" |
Copilot uses AI. Check for mistakes.
| const classes: string[] = ['grid']; | ||
|
|
||
| if (this.cols()) { | ||
| classes.push(`grid-cols-${this.cols()}`); |
There was a problem hiding this comment.
Dynamic CSS class generation may not work properly with Tailwind CSS purging. Consider using a predefined mapping of valid grid classes or ensure these dynamic classes are included in the safelist.
Copilot uses AI. Check for mistakes.
| } | ||
|
|
||
| if (this.rows()) { | ||
| classes.push(`grid-rows-${this.rows()}`); |
There was a problem hiding this comment.
Dynamic CSS class generation may not work properly with Tailwind CSS purging. Consider using a predefined mapping of valid grid classes or ensure these dynamic classes are included in the safelist.
Copilot uses AI. Check for mistakes.
| export class HeaderComponent { | ||
| readonly navItems: NavItem[] = [ | ||
| { | ||
| translationPath: 'nav.guides', | ||
| link: ['guides'], | ||
| dataTestId: 'navigation-guides', | ||
| }, | ||
| { | ||
| translationPath: 'nav.news', | ||
| link: ['news'], | ||
| dataTestId: 'navigation-news', | ||
| }, | ||
| { | ||
| translationPath: 'nav.meetups', | ||
| link: ['https://meetup.angular.love/'], | ||
| externalLink: true, | ||
| dataTestId: 'navigation-meetups', | ||
| }, | ||
| ]; | ||
|
|
There was a problem hiding this comment.
The same navigation items array is duplicated in both HeaderComponent and HeaderMobileMenuComponent. Consider extracting this to a shared constant or service to avoid duplication.
| export class HeaderComponent { | |
| readonly navItems: NavItem[] = [ | |
| { | |
| translationPath: 'nav.guides', | |
| link: ['guides'], | |
| dataTestId: 'navigation-guides', | |
| }, | |
| { | |
| translationPath: 'nav.news', | |
| link: ['news'], | |
| dataTestId: 'navigation-news', | |
| }, | |
| { | |
| translationPath: 'nav.meetups', | |
| link: ['https://meetup.angular.love/'], | |
| externalLink: true, | |
| dataTestId: 'navigation-meetups', | |
| }, | |
| ]; | |
| export const NAV_ITEMS: NavItem[] = [ | |
| { | |
| translationPath: 'nav.guides', | |
| link: ['guides'], | |
| dataTestId: 'navigation-guides', | |
| }, | |
| { | |
| translationPath: 'nav.news', | |
| link: ['news'], | |
| dataTestId: 'navigation-news', | |
| }, | |
| { | |
| translationPath: 'nav.meetups', | |
| link: ['https://meetup.angular.love/'], | |
| externalLink: true, | |
| dataTestId: 'navigation-meetups', | |
| }, | |
| ]; | |
| export class HeaderComponent { | |
| readonly navItems: NavItem[] = NAV_ITEMS; |
Copilot uses AI. Check for mistakes.
|
Deployed to dev environment |
|
PR is detected, will deploy to dev environment |
|
Deployed to dev environment |
No description provided.