Consolidate remapper logic into BaseRemapper and update transformers #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
BaseRemapperwhich centralizesmap/unmap, raw/merged mapping caches,getFieldMap/getMethodMap, andmergeSuperMapslogic (new file:src/main/java/space/libs/asm/BaseRemapper.java).RemapTransformerto extendBaseRemapper, to populaterawFieldMaps/rawMethodMapsfrom the parsedImmutableTableand to use the shared parent-resolution and merging implementation (src/main/java/space/libs/asm/RemapTransformer.java).CustomRemapRemapperto extendBaseRemapper, callfinalizeMappings(...)when loading mappings, and implementgetParentInfo(...)using Forge'sClassPatchManagerto retain Forge-specific parent/interface resolution (src/main/java/space/libs/asm/CustomRemapRemapper.java).getRealName/getLegacyName) while removing duplicate mapping code.Testing
Refactor remapper base) but no build or test tasks (e.g.gradle buildor unit tests) were run in this rollout.Codex Task