Hubspot cell balancer & normalizer#126

Open

szabowexler wants to merge 159 commits intohubspot-2.5from

hubspot-cell-balancer

Commits on Oct 16, 2024

HubSpotCellCostFunction
Ray Mattingly
committed

Commits on Oct 17, 2024

Adjust to handle little endian cell encoding
Elias Szabo
committed
Mark as private
Elias Szabo
committed
Revert to big endian, simplify heuristics
Elias Szabo
committed

Commits on Oct 29, 2024

Fix NPE, add logging, run spotless
Ray Mattingly
committed
Clean up
Elias Szabo
committed

Commits on Oct 30, 2024

Add init debug
Elias Szabo
committed
Clarify expectations via preconditions
Elias Szabo
committed
Update debug and add guard for non default tables
Elias Szabo
committed
Emit setup at info level to ensure we see it
Elias Szabo
committed
Add info state dump on every cost calc call
Elias Szabo
committed

Commits on Oct 31, 2024

Add some debug so we can see why regionlocation would be null
Elias Szabo
committed
emit if we disable locationfinder
Elias Szabo
committed
Ensure the region finder is set if the cell cost function exists
Elias Szabo
committed
Emit the multiplier
Elias Szabo
committed
Missed one spot
Elias Szabo
committed
Fix debug
Elias Szabo
committed
skip any that snuck in, emit better logs, and fail more obviously here
Elias Szabo
committed
include count w/o servers
Elias Szabo
committed
Make it legible
Elias Szabo
committed
list details of the unknown region
Elias Szabo
committed
Emit which table
Elias Szabo
committed
Skip if empty region server mapping, assume it's empty for now
Elias Szabo
committed
Emit the cells in the region here
Elias Szabo
committed
Tell us about which cells this region holds
Elias Szabo
committed
Add emission for region size
Elias Szabo
committed
Make clear if we skip any non-empty regions
Elias Szabo
committed
Include this
Elias Szabo
committed
If the first two bytes of start/stop are the same, the region holds exactly one cell
Elias Szabo
committed
Correct how we calculate the cells
Elias Szabo
committed

Commits on Nov 5, 2024

add a version identifier here
Elias Szabo
committed
This isn't really an edge case so much as the main case
Elias Szabo
committed
Update logging & calcs
Elias Szabo
committed
Use shaded version
Elias Szabo
committed
emit the table name and namespace
Elias Szabo
committed
Switch to multidimensional array to reduce allocations
Elias Szabo
committed

Commits on Nov 6, 2024

Optimize the balancer eval function
Elias Szabo
committed
Deps
Elias Szabo
committed
Add custom step generator for stochastic load to prioritize shuffling regions from high cell count servers to low cell count servers
Elias Szabo
committed
Use our own candidate generator for the stochastic balancer
Elias Szabo
committed
Yep that sure is a 5
Elias Szabo
committed
It has to be the order of the ordinal of course
Elias Szabo
committed

Commits on Nov 7, 2024

Correct reservoir sampling seed, and use boolean[] instead of set
Elias Szabo
committed
Cost is invoked 2-3 times per use, memoize it
Elias Szabo
committed
Filter out non-default regions
Elias Szabo
committed
Prevent being out of bounds
Elias Szabo
committed
Correct off-by-1
Elias Szabo
committed
Add guards here
Elias Szabo
committed
Include the tables
Elias Szabo
committed
Do not emit null actions
Elias Szabo
committed
only use these balancer tools on objects-3
Elias Szabo
committed
This is a bug - only add the cost of the function if it's needed
Elias Szabo
committed
Add a lot of trace logging
Elias Szabo
committed
More logging
Elias Szabo
committed
Trace enough to figure out why cell count is 0
Elias Szabo
committed
Fix the subtle array access bug
Elias Szabo
committed

Commits on Nov 8, 2024

Undo memoization on cluster state change, and allow to trace teh balancer exploration
Elias Szabo
committed
Also emit the full cost breakdown per step
Elias Szabo
committed
Rework the cost function to be the number of cells (over all servers) above the best possible isolation
Elias Szabo
committed
Update debug to focus on which region/cells are getting picked
Elias Szabo
committed
Tweak down to trace
Elias Szabo
committed
Rework how the cost function calculates and updates cost
Elias Szabo
committed
Fix edge case for short rowkeys
Elias Szabo
committed
Merge pull request #120 from HubSpot/isolate-generator-cost-mismatch
szabowexler
authored
Add debug and fix the state error here
Elias Szabo
committed
No noop
Elias Szabo
committed
Print which generator we've selected
Elias Szabo
committed

Commits on Nov 18, 2024

Tweak logs to allow for local run
Elias Szabo
committed
use shaded version
Elias Szabo
committed
Use gson
Elias Szabo
committed
Try exposing only specific fields
Elias Szabo
committed
Only emit objects-3, and include the full region info
Elias Szabo
committed

Commits on Nov 19, 2024

Mark as exposed
Elias Szabo
committed
Refine when we print, and what
Elias Szabo
committed
Update serde for int2int map so we can run the balancer locally
Elias Szabo
committed

Commits on Nov 20, 2024

Stash partial balancer rework
Elias Szabo
committed
Stash2 -- gets to a balance of 1-6 cells/RS
Elias Szabo
committed

Commits on Nov 21, 2024

First cleanup
Elias Szabo
committed
Disable automatic logging for local runs
Elias Szabo
committed
Merge pull request #122 from HubSpot/rework-cell-balancer
szabowexler
authored
Fix test
Elias Szabo
committed

Commits on Nov 26, 2024

Stash work
Elias Szabo
committed
cost is actually how far we are from having as many cells as possible
Elias Szabo
committed
add custom normalizer
Hernan Gelaf-Romer
committed
Revert "add custom normalizer"
Hernan Gelaf-Romer
committed
add hubspot normalizer
Hernan Gelaf-Romer
committed
Prioritize spreading cells out
Elias Szabo
committed
Not for inclusion
Elias Szabo
committed

Commits on Nov 27, 2024

Merge pull request #124 from HubSpot/cell-spread-out
szabowexler
authored

Commits on Dec 2, 2024

Extract static methods, simplify
Elias Szabo
committed
Clean up the candidate generator
Elias Szabo
committed
Elevate to higher package so normalizer can share common cell ops
Elias Szabo
committed
Clean up + normalize cost
Elias Szabo
committed
Update the normalizer to avoid merging across cell lines
Elias Szabo
committed
Mark addition
Elias Szabo
committed
Finish clean up
Elias Szabo
committed
Fix import
Elias Szabo
committed
Print error if cell id is out of bounds
Elias Szabo
committed
Move this up
Elias Szabo
committed
Improve debug output
Elias Szabo
committed

Commits on Dec 3, 2024

Cap max cells per RS to be 10% of all cells
Elias Szabo
committed
Do not install unless multiplier is positive
Elias Szabo
committed

Commits on Dec 4, 2024

Target a specific capped cell count
Elias Szabo
committed
Merge pull request #127 from HubSpot/target-specific-cell-count
szabowexler
authored
Simplify when we fill underloaded
Elias Szabo
committed
include target
Elias Szabo
committed
Emit which generator
Elias Szabo
committed
randomize the under-/overloaded server picked
Elias Szabo
committed
Mark if we keep or reject
Elias Szabo
committed
Print region counts
Elias Szabo
committed
Prioritize balance by region and THEN evening out cell isolation
Elias Szabo
committed
Merge pull request #128 from HubSpot/add-unbalance-dominating-factor
szabowexler
authored

Commits on Dec 5, 2024

Add guard in case of error computing online cost, and do a deep reset if it goes negative
Elias Szabo
committed
Clean MutableRegionInfo
Elias Szabo
committed
Clean up ServerName
Elias Szabo
committed
Clean up TableName
Elias Szabo
committed
Clean up Address
Elias Szabo
committed
Clean up BalancerClusterState
Elias Szabo
committed
Clean up RegionLocationFinder
Elias Szabo
committed
Clean up StochasticLoadBalancer
Elias Szabo
committed
More cleanup StochasticLoadBalancer
Elias Szabo
committed
Clean up RegionNormalizerFactory
Elias Szabo
committed
Merge pull request #129 from HubSpot/clean-up-for-merge
szabowexler
authored
clean imports
Elias Szabo
committed
style
Elias Szabo
committed
Style
Elias Szabo
committed

Commits on Dec 6, 2024

Small clusters may not have enough regions/cell to support lower isolation
Elias Szabo
committed
Merge pull request #130 from HubSpot/handle-small-clusters
szabowexler
authored
Fix which Ints
Elias Szabo
committed

Commits on Dec 16, 2024

Commits on Dec 18, 2024

Measure this distance by region count from balanced
Elias Szabo
committed

Commits on Jan 7, 2025

Set target to 20% of cells
Elias Szabo
committed

Commits on Jan 24, 2025

Split single function into two, and try simple random shuffling
Elias Szabo
committed
Start by just testing live
Elias Szabo
committed
Start at 50%
Elias Szabo
committed

Commits on Jan 27, 2025

Commits on Jan 28, 2025

We were computing perf:iso instead of iso:perf
Elias Szabo
committed
Add a simple debug
Elias Szabo
committed
Use dispersion to describe the concept
Elias Szabo
committed
Fix the formula
Elias Szabo
committed
Better log
Elias Szabo
committed
Allow to run using build, for now
Elias Szabo
committed
Merge pull request #140 from HubSpot/swap-to-dispersion
szabowexler
authored
Include table names
Elias Szabo
committed
Fix mismatch
Elias Szabo
committed
Format that
Elias Szabo
committed
Mark that we only need the cost function if all regions are not system table regions
Elias Szabo
committed
Only needed if multipler is nonzero as well
Elias Szabo
committed
Emit the initial cost
Elias Szabo
committed
Avoid a divide by zero, just treat this server as balanced
Elias Szabo
committed
Have to init this
Elias Szabo
committed
Make sure it's initialized
Elias Szabo
committed
Only do full prep if needed
Elias Szabo
committed
Include table names
Elias Szabo
committed
Try setting to 0.5
Elias Szabo
committed