Skip to content

Fix/use right model for entity details requests #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Viktor-Pelepiak merged 2 commits into from
Oct 13, 2025
Merged

Fix/use right model for entity details requests #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78ed9e1
Use correct model for entity_detailsRequested event
Oct 13, 2025
5c78a56
Remove unused model
Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions .../com/hubspot/slack/client/methods/params/chat/workobject/entity/SlackEntityDetailsIF.java
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions slack-base/src/main/java/com/hubspot/slack/client/models/events/SlackEventType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import com.hubspot.slack.client.enums.EnumIndex;
import com.hubspot.slack.client.methods.params.chat.workobject.entity.SlackEntityDetails;
import com.hubspot.slack.client.models.events.app.SlackAppUninstalledEvent;
import com.hubspot.slack.client.models.events.app.SlackTokensRevokedEvent;
import com.hubspot.slack.client.models.events.assistant.SlackAssistantThreadContextChangedEvent;
Expand All @@ -20,6 +19,7 @@
import com.hubspot.slack.client.models.events.group.SlackGroupOpenEvent;
import com.hubspot.slack.client.models.events.group.SlackGroupRenameEvent;
import com.hubspot.slack.client.models.events.group.SlackGroupUnarchiveEvent;
import com.hubspot.slack.client.models.events.links.EntityDetailsRequestedEvent;
import com.hubspot.slack.client.models.events.links.SlackLinkSharedEvent;
import com.hubspot.slack.client.models.events.user.SlackMemberJoinedChannelEvent;
import com.hubspot.slack.client.models.events.user.SlackMemberLeftChannelEvent;
Expand Down Expand Up @@ -70,7 +70,7 @@ public enum SlackEventType {
IM_HISTORY_CHANGED,
IM_OPEN,
LINK_SHARED(SlackLinkSharedEvent.class),
ENTITY_DETAILS_REQUESTED(SlackEntityDetails.class),
ENTITY_DETAILS_REQUESTED(EntityDetailsRequestedEvent.class),
MEMBER_JOINED_CHANNEL(SlackMemberJoinedChannelEvent.class),
MEMBER_LEFT_CHANNEL(SlackMemberLeftChannelEvent.class),
MESSAGE(SlackEventMessage.class),
Expand Down
5 changes: 3 additions & 2 deletions ...main/java/com/hubspot/slack/client/models/events/links/EntityDetailsRequestedEventIF.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.hubspot.slack.client.models.events.links;

import static org.immutables.value.Value.Immutable;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
Expand All @@ -8,10 +10,9 @@
import com.hubspot.slack.client.methods.params.chat.workobject.ExternalRef;
import com.hubspot.slack.client.models.events.SlackEvent;
import java.util.Optional;
import org.immutables.value.Value;

@Immutable
@HubSpotStyle
@Value.Immutable
@JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy.class)
@JsonDeserialize(as = EntityDetailsRequestedEvent.class)
public interface EntityDetailsRequestedEventIF extends SlackEvent {
Expand Down