Open
Conversation
Abbondanzo
suggested changes
Sep 29, 2022
Contributor
Abbondanzo
left a comment
There was a problem hiding this comment.
One minor nit. The suggestion I provided will only work in modern browsers since Object.entries is not supported by ie11 without polyfill
| // get single value | ||
| el.dataset.foo; | ||
| // set single value | ||
| el.dataset.bar = { value: 42 }; |
Contributor
There was a problem hiding this comment.
JQuery performs serialization with data attributes, so we'll want to stringify/parse these values. Otherwise, they get written as [object Object]. Something like this should work
function data(el, key, value) {
// Return the full dataset
if (key === undefined) {
const toReturn = {};
for (const [dKey, dValue] of Object.entries(el.dataset)) {
try {
toReturn[dKey] = JSON.parse(dValue);
} catch (_) {
// Do nothing
}
}
return toReturn;
}
// "key" is a string, either get or set
else if (typeof key === "string") {
if (value === undefined) {
try {
return JSON.parse(el.dataset[key]);
} catch (_) {
return undefined;
}
} else {
el.dataset[key] = JSON.stringify(value);
}
}
// "key" can be any object, writes each key to dataset
else if (key && typeof key === "object") {
for (const [dKey, dValue] of Object.entries(key)) {
el.dataset[dKey] = JSON.stringify(dValue);
}
}
}
// get all data-* values
data(el);
// get single value
data(el, "foo");
// set single value
data(el, "bar", { value: 42 });
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.