Replacing google poly integration with Icosa integration #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exairnous
reviewed
Nov 18, 2025
src/ui/onboarding/Onboarding.js
Outdated
| componentDidMount() { | ||
| // TODO: Check if object was added | ||
| this.props.editor.setSource("sketchfab"); | ||
| this.props.editor.setSource("poly"); |
Member
There was a problem hiding this comment.
I think this should be "icosa"?
Exairnous
reviewed
Nov 18, 2025
src/editor/nodes/ModelNode.js
Outdated
| getAttribution() { | ||
| // Sketchfab models use an extra object inside the asset object | ||
| // Blender exporters add a copyright property to the asset object | ||
| // Blender & Google Poly exporters add a copyright property to the asset object |
Member
There was a problem hiding this comment.
?
Suggested change
| // Blender & Google Poly exporters add a copyright property to the asset object | |
| // Blender & Icosa Gallery exporters add a copyright property to the asset object |
Exairnous
approved these changes
Dec 15, 2025
Member
There was a problem hiding this comment.
LGTM. Thanks.
Note: this PR depends on Hubs-Foundation/reticulum#743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Poly integration had been removed in the past, but has been reinstated using the new Open Source project Icosa. These changes support that effort.