Skip to content

fixes error in chat commmad permission checking#6093

Open
pattersonbl2 wants to merge 2 commits intomasterfrom
hotfix/load_command
Open

fixes error in chat commmad permission checking#6093
pattersonbl2 wants to merge 2 commits intomasterfrom
hotfix/load_command

Conversation

@pattersonbl2
Copy link
Contributor

Removes this.hubChannel.signIn due to improper function use.

The function will always return true in the if statement, which doesn't validate user sign-in permission.

Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants