Skip to content

add KTX2/Draco loader to avatar-editor #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add KTX2/Draco loader to avatar-editor #6210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c418fb
feat: 🎸 add KTX2/Draco loader to avatar-editor
kira924age Aug 14, 2023
f1f8801
refactor: 💡 remove setKTX2Loader
kira924age Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/react-components/avatar-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ import { ensureAvatarMaterial } from "../utils/avatar-utils";
import AvatarPreview from "./avatar-preview";
import styles from "../assets/stylesheets/avatar-editor.scss";

import { DRACOLoader } from "three/examples/jsm/loaders/DRACOLoader";
import { GLTFLoader } from "three/examples/jsm/loaders/GLTFLoader";
import { getCustomGLTFParserURLResolver } from "../utils/media-url-utils";

import dropdownArrowUrl from "../assets/images/dropdown_arrow.png";
import dropdownArrow2xUrl from "../assets/images/[email protected]";
Expand Down Expand Up @@ -150,10 +152,19 @@ class AvatarEditor extends Component {
e.preventDefault();

if (this.inputFiles.glb && this.inputFiles.glb instanceof File) {
const gltfLoader = new GLTFLoader().register(parser => new GLTFBinarySplitterPlugin(parser));
const gltfUrl = URL.createObjectURL(this.inputFiles.glb);
const loadingManager = new THREE.LoadingManager();
loadingManager.setURLModifier(getCustomGLTFParserURLResolver(gltfUrl));

const gltfLoader = new GLTFLoader(loadingManager).register(parser => new GLTFBinarySplitterPlugin(parser));
const onProgress = console.log;

const dracoLoader = new DRACOLoader(loadingManager);

if (dracoLoader) {
gltfLoader.setDRACOLoader(dracoLoader);
}

await new Promise((resolve, reject) => {
// GLTFBinarySplitterPlugin saves gltf and bin in gltf.files
gltfLoader.load(
Expand Down