Refactor/shared physics validation#6552
Open
HussainAther wants to merge 8 commits intoHubs-Foundation:addonsfrom
Open
Refactor/shared physics validation#6552HussainAther wants to merge 8 commits intoHubs-Foundation:addonsfrom
HussainAther wants to merge 8 commits intoHubs-Foundation:addonsfrom
Conversation
…nd clean up aliases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted
validatePhysicsParams()into a reusable utility function for validating physics configuration values like mass, type, and gravity.Why?
To remove repeated validation code and make it easier to apply consistent validation across components like
body-helper,ragdoll, etc.Examples
mass,type, orgravityvaluesHow to test
mass: "foo")Documentation of functionality
No user-facing docs affected. Dev-only improvement.
Limitations
Only
mass,type, andgravityare validated (for now).Alternatives considered
Inline validation logic in each component — harder to maintain.
Open questions
logWarning()helper for consistent format?Additional details or related context
Supports recent validation work in
body-helper(see #6551)