merges commits from master since 2025-07-29 into addons branch #6574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions of ajv being used by subdepdendencies when running the 'npm run build' target. while the lockfile should prevent this, this can happen when people's build environment is using an older node_modules cache. the cleanest way to fix this for users without manual steps from them is to bump the ajv-referencing packages. with newer eslint and prettier, there are bug fixes where it finds latent problems they missed before. I haven't modified the rule configuration of either, and did the most reasonably minimal fixes for things like unused-variable in error handlers.
…lightly worrying.
…r now. an 'esm' slipped in, causing a crash when running ava tests.
…o make 'npm test' pass in admin dir without running 'npm ci'. 'npm build' in admin dir will not work if 'npm ci' isn't run first.
…and the root: react-admin doesn't support past React 16, and upgrading it has some ripple effects to material-ui. This is a good candidate for the next upgrade slice.
…le with console.error and exend the error modal timeout to a full 10 seconds.
Why: So errors in the log can be mapped to the line of code where it happened
…n-eslint-ajv align dependencies so there isn't mixed versions of the `ajv` subdependency causing errors
…e broken due to them not being kept up to date with components. all pages now display correctly and no console warnings/errors are printed (migration away from old-style required React prop-types was part of this). this should make quick QA verification possible; 2. storybook has been updated to eliminate some race conditions, which necessitated updating webpack, babel, and some older modules whose CommonJS exports were no longer acceptable. Some of these upgrade are incrementally toward updating react-admin (a future PR goal), so it's all good. 3. to clean up the webpack config, the browserlistrc has been updated to exclude pre-WebGL2 and pre-ES7 browsers. This should reduce the bundle size and have a runtime performance uplift since more built-ins will be used instead of JS fallbacks.
Why: not functional without an account of our own
…ck-cron disables scheduled execution of Browserstack testing
…el, but this required bumping our minimum safari version to match pdfjs' constraints. I didn't update to latest so that we can still reasonably support Safari 14.1 (iPhone 6S, iPad Air 2, iPad mini 3), and Chrome 105 (Pico XR 4, Meta Quest 1). This excludes previous support for iOS 10 (iPhone 6, iPad Air) and Chrome 91 (Oculus Go). the typescript config was tightened slightly to try and surface this class of import/export mismatch at build-time in the future.
Why: not functional without an account of our own
… and put a visible vertical scrollbar on the content panel
- Logo stays fixed at top (never scrolls away) - Menu items scroll in dedicated area below logo - Single scroll area - no more double scrolling - Scroll indicators appear/disappear properly when content overflows - Works with Material-UI - no fighting the framework
… broken. fix height calculation issue that clipped the logo image incorrectly. verified bottom arrow still rendering correctly.
…that runs automated tests. Why: There is no native way to include Git hooks in the checked-in code. All solutions require either running a command or installing a 3rd party package. As Hubs developers will almost always run `npm install` after cloning the repo, this approach requires no change in development steps. Note that developers can always prevent a hook from running by adding the flag `-n`, so git hooks just support fail-fast. Enforcement has to occur in CI.
Adds pre-commit hook that runs automated tests & fixes lint errors
What: 1. Removes much of the AI styling changes. 2. Reverts a21f8d4 (show production hubs logo in the storybook...). 3. Changes the custom admin theme to inherit properties from the default theme. 4. Removes the sidebar text color override for mobile. 5. Fixes the issue with the sliding section of the light theme color at the top of the sidebar and ensures the dark theme color extends to the bottom of the sidebar (regardless of browser zoom). 6. Restores the appBar hiding functionality for desktop/large screens. 7. Fixes the issues with the sidebar scrolling by removing the scrolling wrapper and instead overriding the default react-admin sidebar with a custom version that has scrolling indicators that display whenever there is hidden content (either above or below the shown content). Why: 1. The AI styling changes seem to be unnecessary and to have contributed to the visual inconsistencies/glitches. 2. The "show production hubs logo in the storybook..." commit broke the display of the image in deployed instances. 3. Custom themes inheriting properties from the default theme is recommended in the React Admin documentation[1]. 4. The sidebar text color override for mobile is no longer needed (and causes readability issues) now that the background color is the same for both mobile and desktop. 5. It looks better to have the sidebar be a single consistent color from top to bottom. 6. This keeps the behavior of the appBar the same as it was before the Update storybook PR (Hubs-Foundation#6563) 7. There were two scrolling areas, which caused the scrolling to appear erratic, and the scrolling indicators weren't updated live (live updates ensures that people are always aware when the content can be scrolled and in which direction). [1] https://marmelab.com/react-admin/doc/3.19/Theming.html#sidebar-customization
…idebar-scrolling
…rom production scenario so storybook is a closer match. Decompose chrome into a separate file.
…ght viewport with a dark backdrop, matching how the app overlays it so the story no longer appears blmak.
…that runs automated tests. Why: There is no native way to include Git hooks in the checked-in code. All solutions require either running a command or installing a 3rd party package. As Hubs developers will almost always run `npm install` after cloning the repo, this approach requires no change in development steps. Note that developers can always prevent a hook from running by adding the flag `-n`, so git hooks just support fail-fast. Enforcement has to occur in CI.
…missing admin-theme shared file.
Co-authored-by: Exairnous <[email protected]>
…te-storybook Update storybook
Why: Stories didn't exist yet, and they would be confusing without the fixes
Why: the attributions for a remixed scene were neither fully tested nor fully working
Fixes two issues in the Scene UI & adds Storybook test cases for the Scene UI
Why: To move closer to the maintained version
Why: bug fixes & improvements like creation of hyperlinks, improved rendering of large pages & JPEG2000 support
…es without gamepad Why: An error would be thrown, preventing a clean exit from VR mode
Updates PDF.js to latest 5.x version
|
I would be very interested to have this branch updated, since we started to integrate and experiment with behaviour graphs some time ago, but now struggle with errors like not being able to move assets in the scene after dragging them in. |
Member
Author
|
Try using this image from docker hubs in your instance: dougreeder/hubs:addons-2026-02-01-00-53 |
Member
|
@rokru Thank you for your interest, we would like that as well. However, this pull request is only updating the addons branch with the latest changes from the master branch and is unlikely to help with any of the bugs already in the addons branch (such as not being able to move assets in the scene after dragging them in). While it won't fix the issue you mentioned, it would help us if you could check the image @DougReeder linked for any regressions and report any you find here in this pull request. You could also help by checking to see if we've missed documenting any bugs normally found in the addons branch, and if we have, then filing bug reports for them here: https://github.com/Hubs-Foundation/hubs/issues (please include that they are in the addons branch, preferably in the title, e.g. addons: Objects that are added to the room with the A-Frame loader can't be moved). If you, or anyone you know, would like to try fixing one or more of the bugs and submitting a pull request with that fix, you are welcome to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
merges commits from master since 2025-07-29 into addons branch
Why?
To bring Storybook & PDF updates to addons branch
How to test
npm run storybook, surf to http://localhost:6006/?path=/story/scene-ui--base, scan the scene-ui.js cases and skim the other casesDocumentation of functionality
No documentation changes [but Storybook needs to be documented]
Limitations
See the indivdual PRs
Open questions
Is there a more systematic way to test merges from master?