fix: 修复新行字符上升高度小于等于零导致行塌陷问题 #1332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to handle cases where character ascent is negative (e.g., underscores) or zero (e.g., spaces) by setting a minimum ascent value based on font metrics. This ensures proper row height calculation and prevents visual collapse of rows containing such characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前在 #1313 pr反馈过空格折行会触发行塌陷的问题，现在发现下划线折行也会触发行塌陷。
应该是因为下划线的上升高度为负数，作者原来的判断===没有进入，作者修改的是curRow.ascent，没有更新新行的ascent导致。
尝试修复了一下，做为抛砖引玉。
修复前（官网版本）：
修复后：
