Skip to content

Commit c09cfa4

Browse files
authored
Metadata schema updates (#140)
* Change process/protocol_type to type * Change file_format to format * Fix unit tests * Update pipeline-tools version
1 parent 27ce0e9 commit c09cfa4

File tree

7 files changed

+18
-18
lines changed

7 files changed

+18
-18
lines changed

adapter_pipelines/Optimus/adapter.wdl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ workflow AdapterOptimus {
139139
Int max_cromwell_retries = 0
140140
Boolean add_md5s = false
141141

142-
String pipeline_tools_version = "v0.48.3"
142+
String pipeline_tools_version = "v0.49.0"
143143

144144
call GetInputs as prep {
145145
input:

adapter_pipelines/cellranger/adapter.wdl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ workflow Adapter10xCount {
150150
Int max_cromwell_retries = 0
151151
Boolean add_md5s = false
152152

153-
String pipeline_tools_version = "v0.48.3"
153+
String pipeline_tools_version = "v0.49.0"
154154

155155
call GetInputs {
156156
input:

adapter_pipelines/ss2_single_sample/adapter.wdl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ workflow AdapterSmartSeq2SingleCell{
8282
Int max_cromwell_retries = 0
8383
Boolean add_md5s = false
8484

85-
String pipeline_tools_version = "v0.48.3"
85+
String pipeline_tools_version = "v0.49.0"
8686

8787
call GetInputs as prep {
8888
input:

adapter_pipelines/ss2_single_sample/adapter_example_static.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
"AdapterSmartSeq2SingleCell.reference_bundle": "bf51d668-3e14-4843-9bc7-5d676fdf0e01",
1414
"AdapterSmartSeq2SingleCell.format_map": "gs://hca-dcp-mint-test-data/adapters/file_format_map.json",
1515
"AdapterSmartSeq2SingleCell.method": "SmartSeq2SingleCell",
16-
"AdapterSmartSeq2SingleCell.analysis_file_version": "5.3.6",
17-
"AdapterSmartSeq2SingleCell.analysis_protocol_schema_version": "8.0.7",
18-
"AdapterSmartSeq2SingleCell.analysis_process_schema_version": "9.0.0",
16+
"AdapterSmartSeq2SingleCell.analysis_file_version": "6.0.0",
17+
"AdapterSmartSeq2SingleCell.analysis_protocol_schema_version": "9.0.0",
18+
"AdapterSmartSeq2SingleCell.analysis_process_schema_version": "11.0.1",
1919
"AdapterSmartSeq2SingleCell.run_type": "run",
2020
"AdapterSmartSeq2SingleCell.add_md5s": false
2121
}

pipeline_tools/create_analysis_metadata.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def create_analysis_process(
6161
),
6262
'schema_type': SCHEMA_TYPE,
6363
'process_core': get_analysis_process_core(analysis_workflow_id=analysis_id),
64-
'process_type': get_analysis_process_type(),
64+
'type': get_analysis_process_type(),
6565
'timestamp_start_utc': format_timestamp(workflow_metadata.get('start')),
6666
'timestamp_stop_utc': format_timestamp(workflow_metadata.get('end')),
6767
'input_bundles': input_bundles_string.split(','),
@@ -110,7 +110,7 @@ def create_analysis_protocol(
110110
'schema_type': SCHEMA_TYPE,
111111
'protocol_core': get_analysis_protocol_core(pipeline_version=pipeline_version),
112112
'computational_method': method,
113-
'protocol_type': get_analysis_protocol_type(),
113+
'type': get_analysis_protocol_type(),
114114
}
115115
return analysis_protocol
116116

@@ -161,7 +161,7 @@ def get_outputs(output_urls, extension_to_format, schema_url, analysis_file_vers
161161
'schema_type': 'file',
162162
'file_core': {
163163
'file_name': output_url.split('/')[-1],
164-
'file_format': get_file_format(output_url, extension_to_format),
164+
'format': get_file_format(output_url, extension_to_format),
165165
},
166166
}
167167
for output_url in sorted(output_urls)

pipeline_tools/tests/test_create_analysis_metadata.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class Data:
2020
'schema_type': 'file',
2121
'file_core': {
2222
'file_name': 'Aligned.sortedByCoord.out.bam',
23-
'file_format': 'bam',
23+
'format': 'bam',
2424
'checksum': '0123456789abcdef0123456789abcdef',
2525
},
2626
},
@@ -29,7 +29,7 @@ class Data:
2929
'schema_type': 'file',
3030
'file_core': {
3131
'file_name': 'GSM1957573_rna_metrics',
32-
'file_format': 'metrics',
32+
'format': 'metrics',
3333
'checksum': 'abcdef0123456789abcdef0123456789',
3434
},
3535
},
@@ -257,8 +257,8 @@ def verify_outputs(
257257
assert output_json[0]['describedBy'] == schema_url
258258
assert output_json[0]['schema_type'] == 'file'
259259
assert (
260-
output_json[0]['file_core']['file_format']
261-
== expected_outputs[0]['file_core']['file_format']
260+
output_json[0]['file_core']['format']
261+
== expected_outputs[0]['file_core']['format']
262262
)
263263
assert (
264264
output_json[0]['file_core']['file_name']
@@ -272,8 +272,8 @@ def verify_outputs(
272272
assert output_json[0]['describedBy'] == schema_url
273273
assert output_json[1]['schema_type'] == 'file'
274274
assert (
275-
output_json[1]['file_core']['file_format']
276-
== expected_outputs[1]['file_core']['file_format']
275+
output_json[1]['file_core']['format']
276+
== expected_outputs[1]['file_core']['format']
277277
)
278278
assert (
279279
output_json[1]['file_core']['file_name']

pipeline_tools/tests/test_create_envelope.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ def _request_callback(request, context):
443443
'schema_type': 'file',
444444
'file_core': {
445445
'file_name': 'test',
446-
'file_format': 'bam',
446+
'format': 'bam',
447447
'checksum': '0123456789abcdef0123456789abcdef',
448448
},
449449
}
@@ -467,7 +467,7 @@ def _request_callback(request, context):
467467
'schema_type': 'file',
468468
'file_core': {
469469
'file_name': 'test',
470-
'file_format': 'bam',
470+
'format': 'bam',
471471
'checksum': '0123456789abcdef0123456789abcdef',
472472
},
473473
}
@@ -492,7 +492,7 @@ def _request_callback(request, context):
492492
'schema_type': 'file',
493493
'file_core': {
494494
'file_name': 'test',
495-
'file_format': 'bam',
495+
'format': 'bam',
496496
'checksum': '0123456789abcdef0123456789abcdef',
497497
},
498498
}

0 commit comments

Comments
 (0)