Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions web/libs/ui/src/lib/select/select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ export const Select = forwardRef(
pageSize = VARIABLE_LIST_PAGE_SIZE,
page = 1,
itemCount,
onClose,
onOpen,
...props
}: SelectProps<T, A>,
_ref: ForwardedRef<HTMLSelectElement>,
Expand Down Expand Up @@ -143,7 +145,10 @@ export const Select = forwardRef(
valueRef.current = val;
setValue(val);
}
!multiple && setIsOpen(false);
if (!multiple) {
setIsOpen(false);
onClose?.();
}
props?.onChange?.(valueRef.current);
setTimeout(() => {
const changeEvent = new Event("change", {
Expand Down Expand Up @@ -310,7 +315,13 @@ export const Select = forwardRef(
}, [_options, multiple, isSelected, _onChange]);

const combobox = (
<Popover open={isOpen} onOpenChange={setIsOpen}>
<Popover
open={isOpen}
onOpenChange={(_isOpen) => {
setIsOpen(_isOpen);
_isOpen ? onOpen?.() : onClose?.();
}}
>
<PopoverTrigger asChild={true} disabled={disabled}>
<button
variant="outline"
Expand Down
2 changes: 2 additions & 0 deletions web/libs/ui/src/lib/select/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ export type SelectProps<T, A extends SelectOption<T>[]> = {
pageSize?: number;
page?: number;
itemCount?: number;
onClose?: () => void;
onOpen?: () => void;
} & SelectVirtualizedProps &
Omit<React.SelectHTMLAttributes<HTMLSelectElement>, "value" | "placeholder">;

Expand Down
Loading