refactor: ECHO-418: Comments component #8690
Merged
+101
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8690 +/- ##
============================================
- Coverage 67.03% 51.12% -15.91%
============================================
Files 790 551 -239
Lines 60680 38998 -21682
Branches 10311 10313 +2
============================================
- Hits 40677 19939 -20738
+ Misses 20000 19056 -944
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luarmr
force-pushed
the
fb-echo-418/comments-componet
branch
from
4c10044 to
82a70cc
Compare
Migrated CommentFormBase component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="comment-form" tag="form"> with <form className={cn("comment-form")...}>
- Replaced <Elem tag="div" name="primary-action"> with <div className={cn("comment-form").elem("primary-action")...}>
- Preserved ref, mod, onSubmit handler, and all props
- Added type assertion for form ref
- No behavior change, equivalent class strings
Migrated CommentFormButtons component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="comment-form-buttons"> with <div className={cn("comment-form-buttons")...}>
- Replaced <Elem name="buttons"> with <div className={cn("comment-form-buttons").elem("buttons")...}>
- Replaced <Elem name="action" tag="button"> (2x) with <button type="button" className={...}>
- Both action buttons share same elem name (intentional, generates same class)
- Preserved onClick handler, tooltip, and all props
- No behavior change, equivalent class strings
Migrated LinkState component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="link-state"> with <div className={cn("link-state")...}>
- Replaced <Block name="link-state-region"> with <div className={cn("link-state-region")...}>
- Replaced <Elem tag="div" name="prefix"> with <div className={cn("link-state").elem("prefix")...}>
- Replaced all Elems in link-state-region (icon, index, title, label, text, close)
- Nested Elems (label, text within title) all use link-state-region as block
- Preserved style with CSS custom properties (added type assertion)
- Preserved mouse handlers and all props
- No behavior change, equivalent class strings
Migrated CommentsList component from Block to cn() helper.
- Replaced Block import with cn import
- Replaced <Block name="comments-list"> with <div className={cn("comments-list")...}>
- No Elems in this file (simple wrapper)
- No behavior change, equivalent class strings
Migrated Comment/CommentForm component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="comment-form-new" tag="form"> with <form className={cn("comment-form-new")...}>
- Replaced <Elem name="text-row"> with <div className={cn("comment-form-new").elem("text-row")...}>
- Replaced <Elem name="classifications-row"> with <div className={cn("comment-form-new").elem("classifications-row")...}>
- Replaced <Elem name="category-selector"> with <div className={cn("comment-form-new").elem("category-selector")...}>
- Replaced <Elem name="link-state"> with <div className={cn("comment-form-new").elem("link-state")...}>
- Replaced <Elem name="tooltipMessage"> with <div className={cn("comment-form-new").elem("tooltipMessage")...}>
- Preserved form ref, mods, onSubmit handler, and all props
- Added type assertion for form ref
- No behavior change, equivalent class strings
Migrated Comment/CommentItem component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="comment-item"> with <div className={cn("comment-item")...}>
- Replaced <Elem tag={Userpic}> with <Userpic className={cn("comment-item").elem("userpic")...}>
- Replaced <Elem tag="span" name="name"> with <span className={cn("comment-item").elem("name")...}>
- Replaced <Elem component={IconCheck}> with <IconCheck className={cn("comment-item").elem("resolved")...}>
- Replaced all nested Elems (saving, dot, content, text, confirmForm, question, controls, actions, etc.)
- TimeTracker inner component uses parent block "comment-item"
- Nested Elems within content→text→confirmForm all use same block name
- Preserved ref, mods, handlers, and all props
- Added type assertion for ref
- No behavior change, equivalent class strings
Migrated Comments wrapper component from Block to cn() helper.
- Replaced Block import with cn import
- Replaced <Block name="comments"> with <div className={cn("comments")...}>
- No Elems in this file (simple wrapper)
- Wraps either Comment/ or OldComment/ system based on FF_PER_FIELD_COMMENTS flag
- No behavior change, equivalent class strings
luarmr
force-pushed
the
fb-echo-418/comments-componet
branch
from
3f05a87 to
6eb24f6
Compare
yyassi-heartex
approved these changes
Oct 27, 2025
hlomzik
changed the title
hlomzik
changed the title
hlomzik
reviewed
Oct 28, 2025
| {onLinkTo && !region && ( | ||
| <Tooltip title="Link to..."> | ||
| <Elem name="action" tag="button" mod={{ highlight: linking }} onClick={onLinkTo}> | ||
| <button |
There was a problem hiding this comment.
Funny that we missed these buttons when we were refactoring Button component. cc @nick-skriabin
hlomzik
reviewed
Oct 28, 2025
web/libs/editor/src/components/Comments/Comment/CommentItem.tsx
Outdated
Show resolved
Hide resolved
hlomzik
approved these changes
Oct 28, 2025
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bem removal in editor:
Focus on the component:
components/Comments/After merge fflag_feat_all_leap_1430_per_field_comments_100924_short this became more simpler.