Skip to content

fix: FIT-851: The Assign Annotators/ Reviewers modal does NOT always open from Task Actions #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2025
Merged

fix: FIT-851: The Assign Annotators/ Reviewers modal does NOT always open from Task Actions #8699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ab7a71
fix: FIT-851: The Assign Annotators/ Reviewers modal does NOT always …
yyassi-heartex Oct 23, 2025
d0a1b1c
removed memoize and unneded call to actions
yyassi-heartex Oct 24, 2025
b5a4baf
added test id
yyassi-heartex Oct 24, 2025
38788a6
Merge branch 'develop' into 'fb-fit-851/console-cleanup'
yyassi-heartex Oct 26, 2025
d4c1afa
Merge remote-tracking branch 'origin/develop' into fb-fit-851/console…
yyassi-heartex Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions web/libs/datamanager/src/components/DataManager/Toolbar/ActionsButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { IconChevronDown, IconChevronRight, IconTrash } from "@humansignal/icons";
import { Button, Spinner, Tooltip } from "@humansignal/ui";
import { inject, observer } from "mobx-react";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import { Block, Elem } from "../../../utils/bem";
import { FF_LOPS_E_3, isFF } from "../../../utils/feature-flags";
import { Dropdown } from "../../Common/Dropdown/DropdownComponent";
Expand Down Expand Up @@ -205,19 +205,19 @@ export const ActionsButton = injector(
const selectedCount = store.currentView.selectedCount;
const [isOpen, setIsOpen] = useState(false);
const [isLoading, setIsLoading] = useState(false);
const fetchedActionsRef = useRef(false);

const actions = useMemo(() => {
return store.availableActions.filter((a) => !a.hidden).sort((a, b) => a.order - b.order);
}, [store.availableActions]);
const actions = store.availableActions.filter((a) => !a.hidden).sort((a, b) => a.order - b.order);

useEffect(() => {
if (isOpen && actions.length === 0) {
if (isOpen && !fetchedActionsRef.current) {
setIsLoading(true);
store.fetchActions().finally(() => {
setIsLoading(false);
});
fetchedActionsRef.current = true;
}
}, [isOpen, actions, store]);
}, [isOpen, store]);

const actionButtons = actions.map((action) => (
<ActionButton key={action.id} action={action} parentRef={formRef} store={store} formRef={formRef} />
Expand All @@ -227,7 +227,15 @@ export const ActionsButton = injector(
return (
<Dropdown.Trigger
content={
<Menu size="compact">{isLoading ? <Menu.Item disabled>Loading actions...</Menu.Item> : actionButtons}</Menu>
<Menu size="compact">
{isLoading ? (
<Menu.Item disabled data-testid="loading-actions">
Loading actions...
</Menu.Item>
) : (
actionButtons
)}
</Menu>
}
openUpwardForShortViewport={false}
disabled={!hasSelected}
Expand Down
7 changes: 1 addition & 6 deletions web/libs/datamanager/src/stores/AppStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,11 +583,6 @@ export const AppStore = types
}

if (!isLabelStream || (self.project?.show_annotation_history && task)) {
if (self.SDK.type === "dm") {
// Fetch actions in background to avoid blocking the main thread
setTimeout(() => self.fetchActions(), 0);
}

if (self.SDK.settings?.onlyVirtualTabs && self.project?.show_annotation_history && !task) {
requests.push(
self.viewsStore.addView(
Expand Down Expand Up @@ -751,7 +746,7 @@ export const AppStore = types
}

if (actionCallback instanceof Function) {
const result = yield actionCallback(actionParams, view);
const result = actionCallback(actionParams, view);
self.SDK.invoke("actionDialogOkComplete", actionId, {
result,
view: viewReloaded,
Expand Down
Loading