refactor: ECHO-419: BEM Migration: Settings files #8711
Merged
+42
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated SettingsRenderer component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="settings"> with <div className={cn("settings")...}>
- Replaced <Elem name="field"> with <div className={cn("settings").elem("field")...}>
- Preserved onChange handlers and all props
- No behavior change, equivalent class strings
Migrated Settings component from Block/Elem to cn() helper.
- Replaced Block/Elem imports with cn import
- Replaced <Block name="keys"> with <div className={cn("keys")...}>
- Replaced <Elem name="key-group"> with <div className={cn("keys").elem("key-group")...}>
- Replaced <Elem tag="kbd" name="key"> with <kbd className={cn("keys").elem("key")...}>
- Replaced <Block name="settings-tag"> with <div className={cn("settings-tag")...}>
- Replaced <Block name="settings"> in GeneralSettings and LayoutSettings
- Replaced <Elem name="field" tag="label"> with <label className={cn("settings").elem("field")...}>
- Replaced nested <Block name="settings__label"> with <div className={cn("settings__label")...}>
- Replaced nested Elems "title" and "description" within settings__label
- Replaced <Block tag={Modal}> with <Modal className={cn(modalName)...}> and explicit props
- All Elems within each Block scope use correct block name
- Preserved all mods, handlers, and props
- No behavior change, equivalent class strings
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
luarmr
changed the title
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8711 +/- ##
===========================================
- Coverage 66.97% 59.93% -7.05%
===========================================
Files 789 551 -238
Lines 60566 38991 -21575
Branches 10310 10310
===========================================
- Hits 40564 23369 -17195
+ Misses 19999 15619 -4380
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yyassi-heartex
approved these changes
Oct 27, 2025
hlomzik
changed the title
hlomzik
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small migration for BEM in the settings section of the editor.