Skip to content

Conversation

@nass600
Copy link
Contributor

@nass600 nass600 commented Oct 27, 2025

  1. Refactored the empty state for cloud storage
  2. Prepared DataManager to access AuthProvider: needed to check permissions to display or not the Connect Cloud Storage when the project has no data

Before:
Screenshot 2025-10-27 at 11 13 28

After:
Screenshot 2025-10-27 at 11 24 41

@nass600 nass600 requested a review from a team as a code owner October 27, 2025 10:28
@github-actions github-actions bot added the feat label Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit b968f88
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68ff868528b6da000827949c
😎 Deploy Preview https://deploy-preview-8716--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit b968f88
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68ff86850ef72900073c0bc9

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit b968f88
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68ff8685e0ef180008fe59bc
😎 Deploy Preview https://deploy-preview-8716--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit b968f88
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68ff868551a6990008b55ea7

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.17%. Comparing base (9d0feb0) to head (b968f88).
⚠️ Report is 4 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (9d0feb0) and HEAD (b968f88). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (9d0feb0) HEAD (b968f88)
pytests 1 0
lsf-e2e 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8716       +/-   ##
============================================
- Coverage    67.03%   51.17%   -15.87%     
============================================
  Files          790      551      -239     
  Lines        60671    38991    -21680     
  Branches     10310    10310               
============================================
- Hits         40671    19953    -20718     
+ Misses       19997    19035      -962     
  Partials         3        3               
Flag Coverage Δ
lsf-e2e ?
lsf-integration 50.70% <ø> (+0.04%) ⬆️
lsf-unit 8.34% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, but you likely need to update tests to reflect the changes and possibly need to let QA know to update selenium tests

Copy link
Contributor

@ricardoantoniocm ricardoantoniocm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion.

</div>
}
actions={
<div className="flex gap-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="flex gap-2">
<div className="flex gap-base">

@robot-ci-heartex robot-ci-heartex merged commit 0563c9f into develop Oct 27, 2025
45 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-utc-344 branch October 27, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants