-
Couldn't load subscription status.
- Fork 3.1k
feat: FIT-835: Improve customize columns button when Quick View is open #8719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8719 +/- ##
===========================================
- Coverage 66.89% 59.98% -6.92%
===========================================
Files 792 551 -241
Lines 60659 38991 -21668
Branches 10346 10310 -36
===========================================
- Hits 40578 23387 -17191
+ Misses 20078 15601 -4477
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request introduces a significant refactor and UX improvement to the table component, especially for "QuickView" (labeling) mode. The main changes include a unified, sticky toolbar and header for the table in QuickView, a new density toggle for row height, and several code and style cleanups. The toolbar is now always visible and integrated into the scrolling/virtualization logic, while density (row height) can be switched and is persisted. The changes also remove legacy column selector code and update styles for a more consistent look.
Screenshots
Before
After
Table/QuickView UX and Virtualization Improvements:
Refactored the table to support a sticky, always-visible toolbar and header in QuickView mode, integrating them into the virtualization logic and ensuring correct scroll/offset handling. This includes new logic for rendering, positioning, and sizing of toolbar/header rows, and handling scroll events to keep the header in view. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]
Removed old column selector button logic and markup from the QuickView table, consolidating customization controls into the new toolbar. [1] [2]
Density Toggle Feature:
DensityTogglecomponent that allows users to switch between "comfortable" and "compact" row heights. The choice is persisted in localStorage and triggers a global event on change. Integrated the toggle into both the table toolbar and the DataManager toolbar instruments. [1] [2] [3] [4] [5]Styling and Theming Updates:
App.scssto use a new CSS variable. [1] [2] [3]Minor Layout Tweaks: