Skip to content

Conversation

@ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Oct 27, 2025

This pull request introduces a significant refactor and UX improvement to the table component, especially for "QuickView" (labeling) mode. The main changes include a unified, sticky toolbar and header for the table in QuickView, a new density toggle for row height, and several code and style cleanups. The toolbar is now always visible and integrated into the scrolling/virtualization logic, while density (row height) can be switched and is persisted. The changes also remove legacy column selector code and update styles for a more consistent look.

Screenshots

Before

image

After

image image image image

Table/QuickView UX and Virtualization Improvements:

  • Refactored the table to support a sticky, always-visible toolbar and header in QuickView mode, integrating them into the virtualization logic and ensuring correct scroll/offset handling. This includes new logic for rendering, positioning, and sizing of toolbar/header rows, and handling scroll events to keep the header in view. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

  • Removed old column selector button logic and markup from the QuickView table, consolidating customization controls into the new toolbar. [1] [2]

Density Toggle Feature:

  • Added a new DensityToggle component that allows users to switch between "comfortable" and "compact" row heights. The choice is persisted in localStorage and triggers a global event on change. Integrated the toggle into both the table toolbar and the DataManager toolbar instruments. [1] [2] [3] [4] [5]

Styling and Theming Updates:

  • Updated SCSS for the table and toolbar, including new styles for the sticky toolbar, header, and density toggle, plus minor tweaks for consistent sizing and background colors. Also adjusted a gradient in App.scss to use a new CSS variable. [1] [2] [3]

Minor Layout Tweaks:

  • Slightly increased the minimum width for the QuickView data panel from 200px to 202px for improved alignment. [1] [2]

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit f19ef5a
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68ffc65b25cbf900080909d0
😎 Deploy Preview https://deploy-preview-8719--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f19ef5a
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68ffc65cf6ffeb0008720dbe

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit f19ef5a
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68ffc65b1c035c000869af72
😎 Deploy Preview https://deploy-preview-8719--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f19ef5a
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68ffc65b948fb70008ba93b3

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.98%. Comparing base (cb15a51) to head (f19ef5a).
⚠️ Report is 15 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (cb15a51) and HEAD (f19ef5a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cb15a51) HEAD (f19ef5a)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8719      +/-   ##
===========================================
- Coverage    66.89%   59.98%   -6.92%     
===========================================
  Files          792      551     -241     
  Lines        60659    38991   -21668     
  Branches     10346    10310      -36     
===========================================
- Hits         40578    23387   -17191     
+ Misses       20078    15601    -4477     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 54.22% <ø> (+0.12%) ⬆️
lsf-integration 50.70% <ø> (+0.15%) ⬆️
lsf-unit 8.34% <ø> (-0.01%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardoantoniocm ricardoantoniocm self-assigned this Oct 27, 2025
@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review October 27, 2025 19:22
@ricardoantoniocm ricardoantoniocm requested a review from a team as a code owner October 27, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants