Skip to content

return instead of throwing error when socket is not open #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinishi merged 2 commits into from
May 6, 2025
Merged

return instead of throwing error when socket is not open #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b292a68
replace throw with return
yinishi May 6, 2025
65d3f0c
bump beta version
yinishi May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/embed-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@humeai/voice-embed-react",
"version": "0.2.0-beta.1",
"version": "0.2.0-beta.2",
"description": "",
"main": "./dist/index.js",
"module": "./dist/index.mjs",
Expand Down
2 changes: 1 addition & 1 deletion packages/embed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@humeai/voice-embed",
"version": "0.2.0-beta.1",
"version": "0.2.0-beta.2",
"description": "",
"main": "./dist/index.js",
"module": "./dist/index.mjs",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@humeai/voice-react",
"version": "0.2.0-beta.1",
"version": "0.2.0-beta.2",
"description": "",
"main": "./dist/index.js",
"module": "./dist/index.mjs",
Expand Down
15 changes: 8 additions & 7 deletions packages/react/src/lib/useVoiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export const useVoiceClient = (props: {
const sendSessionSettings = useCallback(
(sessionSettings: Hume.empathicVoice.SessionSettings) => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
client.current?.sendSessionSettings(sessionSettings);
},
Expand All @@ -223,7 +223,7 @@ export const useVoiceClient = (props: {
const sendAudio = useCallback(
(arrayBuffer: ArrayBufferLike) => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
client.current?.socket?.send(arrayBuffer);
},
Expand All @@ -233,7 +233,7 @@ export const useVoiceClient = (props: {
const sendUserInput = useCallback(
(text: string) => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
client.current?.sendUserInput(text);
},
Expand All @@ -243,7 +243,7 @@ export const useVoiceClient = (props: {
const sendAssistantInput = useCallback(
(text: string) => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
client.current?.sendAssistantInput({
text,
Expand All @@ -261,7 +261,7 @@ export const useVoiceClient = (props: {
| Hume.empathicVoice.ToolErrorMessage,
) => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
if (toolMessage.type === 'tool_error') {
client.current?.sendToolErrorMessage(toolMessage);
Expand All @@ -274,13 +274,14 @@ export const useVoiceClient = (props: {

const sendPauseAssistantMessage = useCallback(() => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
client.current?.pauseAssistant({});
}, [readyState]);

const sendResumeAssistantMessage = useCallback(() => {
if (readyState !== VoiceReadyState.OPEN) {
throw new Error('Socket is not open');
return;
}
client.current?.resumeAssistant({});
}, [readyState]);
Expand Down