-
Notifications
You must be signed in to change notification settings - Fork 19
Zg/resume on reconnect #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zgreathouse
wants to merge
9
commits into
main
Choose a base branch
from
zg/resume-on-reconnect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bd8c2de
Fix typo in comment on manually maintained files.
zgreathouse a718989
Update ReconnectingWebSocket to enable _url to be updated, add should…
zgreathouse bc10950
Updates ChatSocket to have a shouldResumeChat arg, adds logic for set…
zgreathouse dee8db6
Updates Chat client implement resuming on reconnect by default, with …
zgreathouse bc1d9ff
Updates implementation to only modify query parameters instead of the…
zgreathouse 43297ac
Make ReconnectingWebSocket._url readonly again
zgreathouse 88d2fe6
Fix formatting issues
zgreathouse add9234
Update option name to shouldResumeChatOnReconnect, and update its def…
zgreathouse c19c722
Improves readability of Chat client code, updates _staticShouldAttemp…
zgreathouse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| /** THIS FILE IS MANUALLY MAINAINED: see .fernignore */ | ||
| /** THIS FILE IS MANUALLY MAINTAINED: see .fernignore */ | ||
| export { ChatSocket } from "./Socket"; | ||
| export { Chat } from "./Client"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| /** THIS FILE IS MANUALLY MAINAINED: see .fernignore */ | ||
| /** THIS FILE IS MANUALLY MAINTAINED: see .fernignore */ | ||
| export * from "./types"; | ||
| export * from "./client"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| /** THIS FILE IS MANUALLY MAINAINED: see .fernignore */ | ||
| /** THIS FILE IS MANUALLY MAINTAINED: see .fernignore */ | ||
| export * from "./ws"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO defaulting to true is "breaking" enough that we should highlight it by releasing minor instead of patch wdyt?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twitchard I agree! Although, I am now leaning toward defaulting to
false.It is likely true, in nearly all cases, that users would want to resume a Chat when reconnecting after an unexpected disconnect. However, this current implementation actually breaks when attempting to resume on reconnect if zero data retention is enabled.
There is currently no field in the API which we can leverage to determine whether or not zero data retention has been enabled on the account. Since we are always adding the
resumed_chat_group_idquery param toReconnectingWebSocket._queryParamOverridesupon receiving thechat_metadatamessage, when a new chat unexpectedly disconnects and we try to reconnect it will fail with a E0720 error instead of reconnecting. When receiving this error we need to remove the query param from theReconnectingWebSocket._queryParamOverridesso when it tries to reconnect it won't fail.Apart from that fix, defaulting to
falsewould make the changes here purely additive, while giving users the option to enable resuming on reconnect.