Skip to content

Mini be - #1

Open
KiraniaKharisa wants to merge 15 commits into
mainfrom
mini_be
Open

Mini be#1
KiraniaKharisa wants to merge 15 commits into
mainfrom
mini_be

Conversation

@KiraniaKharisa

Copy link
Copy Markdown
Collaborator

Mengumpulkan Tugas Project Pertama

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ini harusnya yang dipanggil repository nya bukan interface nya

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Middleware nya jangan ditaruh di controller, taruh di routing aja

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yang dipanggil jangan interface nya!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jangan lupa dijadikan json ketika dia error, coba check request yang lain ya

Comment thread app/Models/Setting.php

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pakai trait nya laravel aja gapapa, HasUuid

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SettingInterface dan SettingRepository belum di implement, ini pasti error kalau di running

Comment thread composer.lock Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer loc gaperlu di up ya, kasih git ignore

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diatas kan sudah ada, kenapa dikasih lagi? dan ketika menambah column / merubah harus diberi penjagaan dulu ya.. coba check ke file migration yang lain

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baik mas, maaf kemarin nggk ngecek file" yang lain

@putrapangestu putrapangestu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Masih banyak yang harus di check ya

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pakai uuid ya

Comment thread storage/logs/laravel.log

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storagge log jangan di up ke repo

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ini jadi jadi pakai bawaan GetInterface atau mau bikin sendiri get function nya?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coba check coment atas ya

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List index semua dipakai kan paginate ya, kalau mau no paginate dibuat function sendiri

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User role nya belum di sync

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List index semua dibuat paginate ya, kalau mau no paginate buat function baru

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message nya mana?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mana message nya

Comment thread app/Models/Role.php

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ini gapakai uuid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants