refactor(fs): rename and add docstrings to fs functions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem We will rename Application Composer to Infrastructure Composer as our service name. We need to do the same thing in VSCode toolkit ## Solution We will rename all user visible things first
make auth container responsive # Before - The content scales down to 0.6x when the width in less than 260px https://github.com/user-attachments/assets/d38db517-4734-435f-8100-b6a65d502c75 # After ## Login Screen https://github.com/user-attachments/assets/17b579e1-003f-42aa-967e-7565e66624f0 ## Re-Auth Screen https://github.com/user-attachments/assets/2cd8754d-6707-4cd4-a250-7b28a0cd7de5 License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Description Updated the legal disclaimer text in the footer of the chat client. This is done as a clarification of compliant use according to the AWS AI policy.
We dont need this code anymore --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
## Problem - withPerformance was an experiment to see if we could correlate cpu/memory with number of files ## Solution - Cpu usage/memory usage in the extension host is way too volitile so we might as well clean up this code --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem IamPolicyChecks currently has no unit tests. This makes the feature fragile to changes and at risk to breaking changes. ## Solution Implement unit tests for IamPolicyChecks feature.
## Problem We want to avoid fs-extra, and eventually move it to the banned import list. As a first step, we remove fs-extra with as much of our own `fs.ts` work, and `fs` when not possible. ## Solution - Replace `ensureDir` with `mkDir` as suggested here: https://github.com/jprichardson/node-fs-extra/blob/HEAD/docs/ensureDir.md - Also `ensureDir` with permissions arg can be `mkDir` with `chmod` following. - Replace `move` with `rename` since we aren't using virtual file system, or crossing disk partitions: https://stackoverflow.com/questions/8579055/how-do-i-move-files-in-node-js
## Problem There is a test from recent PR that is incorrect given current structure. Ex. https://github.com/aws/aws-toolkit-vscode/actions/runs/11149044046/job/30987024464 Using `globals.context.asAbsolutePath` will prepend `toolkit` to the path, whereas we want to look in `core` for this file. ## Solution - Manually construct the path to be checked.
## Problem - `/dev` conversation would got terminated by retry-able errors, since we disabled the default retry. ## Solution - Re-enable the default to prevent `/dev` from terminated by transient/retry-able errors.
…fication (aws#5696) ## Problem Product thinks that code percentage event should not consider user modification ## Solution use raw accepted token count (without considering modification) for the percentage field in toolkit telemetry there is no change to STE --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Co-authored-by: Justin M. Keyes <[email protected]>
Hweinstock
pushed a commit
that referenced
this pull request
Oct 25, 2024
telemetry(amazonq): use ui_click telemetry for stop code generate button instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up from: aws#5689
Solution
readFilefunctions to be more clear about what they expect.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.