Skip to content

Resolve CI errors#23

Merged
AkshayThiru merged 7 commits intoHybridRobotics:mainfrom
AkshayThiru:ci-fix
Mar 30, 2026
Merged

Resolve CI errors#23
AkshayThiru merged 7 commits intoHybridRobotics:mainfrom
AkshayThiru:ci-fix

Conversation

@AkshayThiru
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to resolve CI/build failures by relaxing Eigen requirements, removing Eigen-dependent 2D cross usage in Graham scan, and adjusting tests/CI configuration to better match Ubuntu runner dependencies.

Changes:

  • Update Eigen discovery/version expectations (CMake + README) and add apt-installed native deps in CI.
  • Remove Eigen .cross() usage for 2D vectors in Graham scan (and tests) to avoid Eigen API incompatibilities.
  • Adjust/trim tests and CI jobs to reduce current CI breakage (e.g., remove an unstable derivative test and drop wheel/coverage jobs).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
CMakeLists.txt Switch Eigen discovery to non-versioned find_package(Eigen3 ...) and log detected version.
README.md Lower documented Eigen requirement to 3.4+.
docs/Usage.md (Not changed) Still references Eigen 5.0 in example; flagged as inconsistent with README.
.github/workflows/ci.yml Install Eigen/Qhull via apt for CI jobs; remove wheel build/test and C++ coverage jobs.
src/graham_scan.cc Replace 2D .cross() call with explicit determinant formula; remove <Eigen/Dense> include.
tests/graham_scan_test.cc Mirror Graham scan CCW computation change; remove <Eigen/Dense> include.
tests/local_geometry_test.cc Fix expected normal-cone basis for a 3D capsule zero-margin case.
tests/solution_derivative_test.cc Remove EllipsoidMesh derivative test that likely caused CI instability.
python/README.md Remove wheel-building instructions (aligned with removal of wheel CI jobs).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:50

  • The CI workflow no longer builds/tests a wheel install and no longer runs the C++ coverage job. If those checks are still intended to be part of CI quality gates, consider re-adding them (e.g., fix the original failures by installing native deps in those jobs as well, or move them to a scheduled/nightly workflow rather than removing entirely).
  cpp-build-test:
    runs-on: ubuntu-latest
    name: Build and test C++ library
    steps:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AkshayThiru AkshayThiru merged commit 794cc56 into HybridRobotics:main Mar 30, 2026
10 checks passed
@AkshayThiru AkshayThiru deleted the ci-fix branch March 30, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants