Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve CI/build failures by relaxing Eigen requirements, removing Eigen-dependent 2D cross usage in Graham scan, and adjusting tests/CI configuration to better match Ubuntu runner dependencies.
Changes:
- Update Eigen discovery/version expectations (CMake + README) and add apt-installed native deps in CI.
- Remove Eigen
.cross()usage for 2D vectors in Graham scan (and tests) to avoid Eigen API incompatibilities. - Adjust/trim tests and CI jobs to reduce current CI breakage (e.g., remove an unstable derivative test and drop wheel/coverage jobs).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Switch Eigen discovery to non-versioned find_package(Eigen3 ...) and log detected version. |
README.md |
Lower documented Eigen requirement to 3.4+. |
docs/Usage.md |
(Not changed) Still references Eigen 5.0 in example; flagged as inconsistent with README. |
.github/workflows/ci.yml |
Install Eigen/Qhull via apt for CI jobs; remove wheel build/test and C++ coverage jobs. |
src/graham_scan.cc |
Replace 2D .cross() call with explicit determinant formula; remove <Eigen/Dense> include. |
tests/graham_scan_test.cc |
Mirror Graham scan CCW computation change; remove <Eigen/Dense> include. |
tests/local_geometry_test.cc |
Fix expected normal-cone basis for a 3D capsule zero-margin case. |
tests/solution_derivative_test.cc |
Remove EllipsoidMesh derivative test that likely caused CI instability. |
python/README.md |
Remove wheel-building instructions (aligned with removal of wheel CI jobs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:50
- The CI workflow no longer builds/tests a wheel install and no longer runs the C++ coverage job. If those checks are still intended to be part of CI quality gates, consider re-adding them (e.g., fix the original failures by installing native deps in those jobs as well, or move them to a scheduled/nightly workflow rather than removing entirely).
cpp-build-test:
runs-on: ubuntu-latest
name: Build and test C++ library
steps:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.