CWMS-Vue-745: Reimplementing av_location_level and av_virtual_location_level #104
Open
zack-rma wants to merge 31 commits intoHydrologicEngineeringCenter:mainfrom
Open
CWMS-Vue-745: Reimplementing av_location_level and av_virtual_location_level #104zack-rma wants to merge 31 commits intoHydrologicEngineeringCenter:mainfrom
zack-rma wants to merge 31 commits intoHydrologicEngineeringCenter:mainfrom
Conversation
…ocation_level -splitting av_location_level_ref and av_location_level_values where av_location_level_ref is designed for pagination via CDA and av_location_level_values are decorated by the paginged location_level_codes in the initially filtered av_location_level_ref - units are handled via _EN and _SI columns instead of having additional rows. This matches av_virtual_location_level, but not av_location_level - sorting is not based on fully concatenated location_level_id, but instead of the constituent parts so that full table scan isn't needed prior to sort. no sorting done within the views
Contributor
Author
|
To quantify the improvement in the view, I compared the execution plans for the level retrieval query from CDA between the original view and the new views. The tested query returned two stored constant level records. When retrieving against the old views, approximately 800kb of temporary space is used. The total CPU cost is 1094, with hundreds of rows being accessed to achieve this result. This view also uses full outer joins. When retrieving against the new views, no temporary space is used. The total CPU cost is 44, with only a few rows being accessed to achieve this result. When run against the NWDP database export containing significantly more rows, the space usage of the original query was recorded using dozens of GB of space to retrieve the results. The new query achieves the same goal using an order of magnitude fewer resources. Query 1: Explain Plan results: New Query: Explain Plan results: |
adamkorynta
requested changes
Feb 13, 2026
This reverts commit 87ec5bd.
adamkorynta
requested changes
Feb 20, 2026
zack-rma
force-pushed
the
feature/loc_lvl_view_optimization
branch
from
2cd617b to
a54421e
Compare
This reverts commit a54421e.
…efinition, added grant to test definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of work from #99
Adds tests and documentation
initial performance improvement seen to drop from 90+ seconds for 1000 row retrieval to ~2 seconds for 1000 location level id retrieval (there are actually more than 1000 rows returned because seasonal values are normalized)